Bug 333005 - Customized External Browser is not used
Summary: Customized External Browser is not used
Status: NEW
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: ATF (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-21 07:05 EST by Roy Ganor CLA
Modified: 2020-05-07 10:51 EDT (History)
1 user (show)

See Also:

Attachments
patch (13.18 KB, patch)
2010-12-21 07:05 EST, Roy Ganor CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roy Ganor CLA 2010-12-21 07:05:31 EST 
1. In preferences select External browser and change the system default browser
2. Open a browser 

Expected - the specified browser is opened
Actual - the system browser is opened
Comment 1 Roy Ganor CLA 2010-12-21 07:05:56 EST 
Created attachment 185626 [details]
patch
Comment 2 Jacek Pospychala CLA 2010-12-21 09:39:02 EST 
I don't like the iexplore path editing. Can't we simply use "iexplore.exe"? It should always be on path.
I don't know what is returned by BrowserManager.getCurrentWebBrowser(). It will return browser selected by user, yes?
I also don't understand this change:

+		} else {
+			if ((style & IWorkbenchBrowserSupport.AS_VIEW) != 0)
+				webBrowser = new InternalBrowserViewInstance(browserId, style,
+						name, tooltip);
+			else
+				webBrowser = new InternalBrowserEditorInstance(browserId,
+						style, name, tooltip);
+		}

does it mean that in some circumstances, the Platform's internal browser will be used?