Bug 332502 - List view in Search pane does not show all found results as does the Tree view
Summary: List view in Search pane does not show all found results as does the Tree view
Status: ASSIGNED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Search (show other bugs)
Version: 3.7   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform-Search-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-14 05:00 EST by donescamillo Mising name CLA
Modified: 2017-07-30 16:36 EDT (History)
3 users (show)

See Also:


Attachments
patch (26.52 KB, patch)
2014-04-04 12:43 EDT, vishal CLA
vishal.vit: review?
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description donescamillo Mising name CLA 2010-12-14 05:00:46 EST
Build Identifier: Helios Service release one

When one searches for a string and the string is found a number of times and the Search pane is configured as Tree view, all the lines in source code where the string was found are shown (upon tree expansion). The user sees them all, without having to navigate through files etc. and double-clicking on a line takes the user to the corresponding file.
If the Search pane is configured as List view, only the number of occurrences is shown, individual lines in code are not. 
Of course one can use the tree view but the expanded tree view takes too much space on screen.

Reproducible: Always

Steps to Reproduce:
1. Do a file search for a string (a function name, a variable) 
2. Make sure Search pane is configured as Tree view
3. Upon tree expansion one can see all the lines where the string was found. Double clicking any of them takes user to the file where the line is
4. Change view to List view
5. Only the number of occurrences is shown, individual files are not.
Comment 1 Dani Megert CLA 2010-12-14 05:32:43 EST
There are no plans to change this. This interested to see all the individual matches can use the tree view.
Comment 2 Markus Keller CLA 2014-03-27 12:14:14 EDT
(In reply to donescamillo Mising name from comment #0)
> Of course one can use the tree view but the expanded tree view takes too
> much space on screen.

An alternative solution could be to add a "Compressed Folders" option that works similar to some Synchronization view pages
Comment 3 vishal CLA 2014-04-04 12:43:09 EDT
Created attachment 241620 [details]
patch
Comment 4 vishal CLA 2014-04-04 12:44:36 EDT
Comment on attachment 241620 [details]
patch

I have created a patch for this bug with eclipse kepler version
It will be really nice if someone can review it.

Thanks,
Vishal
Comment 5 Dani Megert CLA 2014-04-24 06:14:21 EDT
Vishal, you need to sign the CLA and confirm that you want to contribute this by adding the following comment:

This contribution complies with http://www.eclipse.org/legal/CoO.php
Comment 6 vishal CLA 2014-04-25 15:03:28 EDT
Dani, I have signed the CLA. Please let me know if anything else need to be done from my side.
Comment 7 Dani Megert CLA 2014-04-26 04:18:46 EDT
(In reply to vishal from comment #6)
> Dani, I have signed the CLA. Please let me know if anything else need to be
> done from my side.

Yes confirm explicitly that you contribute your patch under the CLA (see last sentence in comment 5).
Comment 8 vishal CLA 2014-04-26 04:25:57 EDT
I have added the patch for this bug and I want to contribute this patch to eclipse.

This contribution complies with http://www.eclipse.org/legal/CoO.php

Thanks,
Vishal
Comment 9 vishal CLA 2016-04-25 11:51:44 EDT
Anything else is required from my side for contributing this patch in eclipse ?
Comment 10 Dani Megert CLA 2016-04-25 13:06:57 EDT
(In reply to vishal from comment #9)
> Anything else is required from my side for contributing this patch in
> eclipse ?

No. Just too busy with other stuff. Sorry.
Comment 11 Dani Megert CLA 2017-07-30 15:34:14 EDT
I'm moving this back to the inbox as I currently don't have time for this.

 vishal you would have to resign the CLA and preferably upload the patch as Gerrit change.