Bug 331935 - Patch too big
Summary: Patch too big
Status: ASSIGNED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: CVS (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows All
: P3 minor (vote)
Target Milestone: ---   Edit
Assignee: platform-cvs-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-12-06 13:39 EST by Markus Keller CLA
Modified: 2019-09-06 16:09 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2010-12-06 13:39:18 EST 
I20101205-2000

The patch in attachment 184645 [details] (bug 331670 comment 2) is too big. When you apply it to org.eclipse.pde.ui, you see that the changes in LauncherUtilsStatusHandler.java are not that big. I've verified that the file is set to ASCII mode in CVS (-kkv).
Comment 1 Markus Keller CLA 2010-12-06 13:46:31 EST 
Hmm, I checked the file on the server with hexdump -c, and I saw that it's stored with \r\n as line endings. That shouldn't be the case for a text file. Other files nearby are looking good (e.g. LaunchAction.java,v).
Comment 2 Curtis Windatt CLA 2010-12-06 13:46:49 EST 
We have seen this a few times before in PDE.  I believe the issue was that some files had different line ending in CVS and the diff included them in the patch.  When applying the patch you can ignore whitespace changes to only see what code the patch changes.
Comment 3 Tomasz Zarna CLA 2010-12-07 05:30:48 EST 
Weird indeed, I've just managed to create such a big patch (whole file removed and then added) just after I updated copyright year in the LauncherUtilsStatusHandler's header.
Comment 4 Eclipse Webmaster CLA 2019-09-06 16:09:59 EDT 
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.