Bug 331805 - Need to add a new Oracle dependency - orai18n-mapping.jar that is required by Oracle DB certification
Summary: Need to add a new Oracle dependency - orai18n-mapping.jar that is required by...
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Eclipselink (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Nobody - feel free to take it CLA
QA Contact:
URL:
Whiteboard:
Keywords: test
Depends on:
Blocks:
 
Reported: 2010-12-03 13:44 EST by Edwin Tang CLA
Modified: 2022-06-09 10:26 EDT (History)
2 users (show)

See Also:
eric.gwin: review+

Attachments
patch file (13.11 KB, patch)
2010-12-03 14:57 EST, Edwin Tang CLA 		no flags Details | Diff
the 2nd patch (4.97 KB, patch)
2010-12-15 11:26 EST, Edwin Tang CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Edwin Tang CLA 2010-12-03 13:44:27 EST 
We need to add a new Oracle dependency - orai18n-mapping.jar that is required by Oracle DB certification. It is used along with xmlparserv2.jar.
Comment 1 Edwin Tang CLA 2010-12-03 14:57:41 EST 
Created attachment 184503 [details]
patch file

1. Added a property 
oracle.orai18n-mapping.jar=orai18n-mapping.jar
2. Changed other Oracle-specific property names to follow the naming convention
Comment 2 Eric Gwin CLA 2010-12-06 11:07:34 EST 
Patch looks good, but it should be noted that jpa.test hasn't yet been converted to the new (newer) standards, so changes there are acceptable to the old methods, but will need to be revisited.
Comment 3 Edwin Tang CLA 2010-12-06 15:52:58 EST 
The patch has been checked into 2.0, 2.1 and trunk.
Code reviewed by: Yiping Zhao and Eric Gwin
Comment 4 Edwin Tang CLA 2010-12-06 15:55:01 EST 
We have a single CQ for compiling dependencies on Oracle jars(ojdbc*.jar, apapi.jar, sdoapi.jar, xdb.jar and xmlparserv2.jar), orai18n-mapping.jar is not a compiling dependency but for passing Oracle-specific tests, no CQ is needed.
Comment 5 Edwin Tang CLA 2010-12-07 15:57:25 EST 
Fixed jpa/eclipselink.jpa.test/<server_name>.xml in 2.0 and trunk. will check into 2.1 when it is open.
Comment 6 Edwin Tang CLA 2010-12-15 11:26:58 EST 
Created attachment 185238 [details]
the 2nd patch
Comment 7 Edwin Tang CLA 2010-12-15 15:07:11 EST 
The second patch has been checked into 2.1 branch.
Comment 8 Eclipse Webmaster CLA 2022-06-09 10:26:56 EDT 
The Eclipselink project has moved to Github: https://github.com/eclipse-ee4j/eclipselink