Bug 331262 - [patch] Make "Open Manifest" bound to a command
Summary: [patch] Make "Open Manifest" bound to a command
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 3.8 M2   Edit
Assignee: Curtis Windatt CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, contributed
: 256433 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-11-26 19:54 EST by Sam Davis CLA
Modified: 2013-04-16 10:09 EDT (History)
4 users (show)

See Also:


Attachments
Patch of commit 06c4256a87bef2175c2f28f25b00ae58733f176e (12.96 KB, patch)
2011-09-09 09:41 EDT, Ben Cox CLA
john.arthorne: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Davis CLA 2010-11-26 19:54:28 EST
It would be nice if there were a command for the "Open Manifest" action in the "PDE Tools" menu that had a key binding, and would work on the currently selected resource or active editor.
Comment 1 Ben Cox CLA 2011-08-17 15:53:25 EDT
I'd be happy to work on this - and I'd appreciate it once it was done! :-) Curtis, could you transfer it to me?
Comment 2 Curtis Windatt CLA 2011-08-17 16:32:51 EDT
Finding a useful, but free key binding, may be difficult.  At a minimum having the command available on the keys pref page will be useful.
Comment 3 Ben Cox CLA 2011-09-09 08:54:19 EDT
I've fixed this and committed it to my github fork of eclipse.pde.ui. First time I've used Git etc, so I'm just getting to grips with the concepts! The commit is available at https://github.com/ind1go/eclipse.pde.ui/commit/06c4256a87bef2175c2f28f25b00ae58733f176e, from which you can hopefully pull it into your repo and make any changes you think necessary.

The command is currently set to the memorable keystroke Ctrl+Shift+Alt+M. You should be able to hit it when focused on most resources and get the relevant manifest.

I've updated "Open Manifest" from action-based to command/handler-based, and as such have renamed OpenManifestAction to OpenManifestHandler.

Hope that's all OK - let me know if a plain old patch would be more appreciated!
Comment 4 Curtis Windatt CLA 2011-09-09 09:23:03 EDT
Can you please attach the patch to this bug. I'm not aware if the Eclipse Foundation has defined a way to do due diligence (ip log) for github.
Comment 5 Ben Cox CLA 2011-09-09 09:41:06 EDT
Created attachment 203058 [details]
Patch of commit 06c4256a87bef2175c2f28f25b00ae58733f176e

Sure thing - attached. I saw this page, but I'm not sure whether it's an approved process yet: http://wiki.eclipse.org/Development_Resources/Handling_Git_Contributions

If it an approved process, then...

I wrote all the code in commit 06c4256a87bef2175c2f28f25b00ae58733f176e above and have the rights to contribute it to Eclipse under the eclipse.org web site terms of use.
Comment 6 Curtis Windatt CLA 2011-09-09 13:15:31 EDT
> Sure thing - attached. I saw this page, but I'm not sure whether it's an
> approved process yet:
> http://wiki.eclipse.org/Development_Resources/Handling_Git_Contributions
> 
> If it an approved process, then...
> 
> I wrote all the code in commit 06c4256a87bef2175c2f28f25b00ae58733f176e above
> and have the rights to contribute it to Eclipse under the eclipse.org web site
> terms of use.
.
The fix adds the command/key binding as promised. Changes look good. It looks like this is an approved process. I think we have followed all of the necessary steps.

Fixed in master
http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=ea44007a37c60f475268c5a5a97c0fa3801ec5e1
Comment 7 Ankur Sharma CLA 2011-09-14 05:48:32 EDT
Verified in I20110913-0200
Comment 8 Curtis Windatt CLA 2013-04-16 10:09:40 EDT
*** Bug 256433 has been marked as a duplicate of this bug. ***