Bug 256433 - Provide Keyboard shortcur to PDE-"Open Manifest" for the current project
Summary: Provide Keyboard shortcur to PDE-"Open Manifest" for the current project
Status: CLOSED DUPLICATE of bug 331262
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4.2   Edit
Hardware: All All
: P3 enhancement with 1 vote (vote)
Target Milestone: ---   Edit
Assignee: PDE-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday
Depends on:
Blocks:
 
Reported: 2008-11-25 08:41 EST by Stefan Winkler CLA
Modified: 2013-04-16 10:09 EDT (History)
5 users (show)

See Also:


Attachments
Patch (as a starting point - incomplete) (11.40 KB, patch)
2008-11-25 11:39 EST, Stefan Winkler CLA
no flags Details | Diff
project-submenu.patch (15.05 KB, patch)
2009-09-17 20:39 EDT, thomas menzel CLA
no flags Details | Diff
project-submenu-helios-SR1.patch (58.66 KB, patch)
2010-12-18 17:04 EST, thomas menzel CLA
no flags Details | Diff
project-submenu-indigo (57.93 KB, patch)
2011-07-21 21:06 EDT, thomas menzel CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Winkler CLA 2008-11-25 08:41:04 EST
I'd like to see a keybinding (or the possibility to create one) for org.eclipse.pde.ui.OpenManifestAction.
Comment 1 Chris Aniszczyk CLA 2008-11-25 08:51:49 EST
Care to attach a patch :)?

It would make it go faster :P
Comment 2 Stefan Winkler CLA 2008-11-25 11:37:58 EST
I started to try. However, I cannot complete it.

First of all, the PDE tools menu is implemented as objectContributions/Actions while keybindings ask for commands and using the org.eclipse.ui.menus extension point. So that item would have to be refactored. 

The patch I have attached starts doing this for the Open Manifest command, however you might want to change command category ID and command ID and so on...

Then I realized, that what I wanted is not simply a shortcut from the menuitem (that is, if the Plugin-Project is already selected), but e.g., from within a Java editor. What I'd like is a more or less omnipresent command which can navigate to the Manifest Editor of the Plugin-Project of the currently selected file or of the file whose editor is active.

Maybe this can be achieved by enhancing the logic in the command handler and by providing another context for the command, but I am not so mucht into the platform at that point, so I can not figure out easily.  

I hope that the attached patch can serve as a starting point ...
Comment 3 Stefan Winkler CLA 2008-11-25 11:39:11 EST
Created attachment 118669 [details]
Patch (as a starting point - incomplete)
Comment 4 thomas menzel CLA 2009-09-17 12:17:30 EDT
i 2nd this notion and thought of this like so:

add a menu entry to the Project menu named "Open &Manifest"

if the currently selected resource of the view or editor is part of a plugin project.

giving it a try based on the patch given here
Comment 5 thomas menzel CLA 2009-09-17 20:39:18 EDT
Created attachment 147512 [details]
project-submenu.patch 

this patch will add the submenu "PDE To&ols" to project/additions containing actions to open the manifest editor in diff. pages.

i hope u guys like it. 

the patch is against the latest tag: v20090202 (Version)
Comment 6 thomas menzel CLA 2009-09-17 20:41:55 EDT
uh, i forgot: 

at the end of my hacking i saw that there might be an official way to pass parameters from the plugin.xml involving IExecutableExtension  but i didnt bother to investigate that matter deeper, as it is getting very late/early...
Comment 7 thomas menzel CLA 2010-12-18 17:04:43 EST
Created attachment 185486 [details]
project-submenu-helios-SR1.patch
Comment 8 Curtis Windatt CLA 2010-12-20 14:14:10 EST
I would support a patch that made the open manifest action a command, available on the keybindings pref page.  However, the project menu is deliberately small and uncluttered and I am hesitant to add new items to it.
Comment 9 Jeff McAffer CLA 2010-12-23 12:13:12 EST
would love to have a fast way of opening the manifest for the current "context".  Getting it on the project somehow would be cool.  Also interesting to get it on arbitrary resources. Basically open the manifest for the current "thing".
Comment 10 thomas menzel CLA 2010-12-23 12:19:58 EST
(In reply to comment #9)
> would love to have a fast way of opening the manifest for the current
> "context".  Getting it on the project somehow would be cool.  Also interesting
> to get it on arbitrary resources. Basically open the manifest for the current
> "thing".

hi jeff,

this is what my patch does. try it. works like a charm and i cant live w/o it anymore when doing bundle development.

also notice that this is still a hack, having little knowledge of how to do things right or really well in the eclipse plugin world. e.g. i didnt bother of finding out if the current project is actually a plugin and depending on that en/disable the menu entry. making this a part of a command group that can be disabled would be nice too for those not doing plugins/bundles, etc.
Comment 11 thomas menzel CLA 2010-12-29 11:01:56 EST
i also noticed that the current patch doesnt work with source bundles, ie. where u look at the code alright with source bundles but the code doesnt live in the workspace.
Comment 12 thomas menzel CLA 2011-07-21 21:06:01 EDT
Created attachment 200137 [details]
project-submenu-indigo
Comment 13 Ben Cox CLA 2013-04-16 05:46:41 EDT
I think this is a duplicate of bug 331262.
Comment 14 Curtis Windatt CLA 2013-04-16 10:09:40 EDT

*** This bug has been marked as a duplicate of bug 331262 ***