Bug 329277 - Compiler failures in N20101101-2000
Summary: Compiler failures in N20101101-2000
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Runtime (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 3.7 M4   Edit
Assignee: platform-runtime-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-11-02 13:18 EDT by Olivier Thomann CLA
Modified: 2010-11-09 16:05 EST (History)
3 users (show)

See Also:


Attachments
Proposed fix (11.06 KB, patch)
2010-11-02 13:18 EDT, Olivier Thomann CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Thomann CLA 2010-11-02 13:18:17 EDT
1. ERROR in /src/org/eclipse/core/internal/registry/ExtensionHandle.java
 (at line 13)
import org.eclipse.core.runtime.IPluginDescriptor;
The import org.eclipse.core.runtime.IPluginDescriptor cannot be resolved
2. ERROR in /src/org/eclipse/core/internal/registry/ExtensionHandle.java
 (at line 30)
public IPluginDescriptor getDeclaringPluginDescriptor() throws InvalidRegistryObjectException {
IPluginDescriptor cannot be resolved to a type
3. ERROR in /src/org/eclipse/core/internal/registry/ExtensionHandle.java
 (at line 32)
IPluginDescriptor result = RegistryCompatibilityHelper.getPluginDescriptor(namespace);
IPluginDescriptor cannot be resolved to a type
4. ERROR in /src/org/eclipse/core/internal/registry/ExtensionHandle.java
 (at line 32)
IPluginDescriptor result = RegistryCompatibilityHelper.getPluginDescriptor(namespace);
The method getPluginDescriptor(String) from the type RegistryCompatibilityHelper refers to the missing type IPluginDescriptor
5. ERROR in /src/org/eclipse/core/internal/registry/ExtensionHandle.java
 (at line 38)
result = RegistryCompatibilityHelper.getPluginDescriptor(hosts[0].getSymbolicName());
The method getPluginDescriptor(String) from the type RegistryCompatibilityHelper refers to the missing type IPluginDescriptor

1. ERROR in /src/org/eclipse/core/internal/registry/ExtensionPointHandle.java
 (at line 13)
import org.eclipse.core.runtime.IPluginDescriptor;
The import org.eclipse.core.runtime.IPluginDescriptor cannot be resolved
2. ERROR in /src/org/eclipse/core/internal/registry/ExtensionPointHandle.java
 (at line 28)
public IPluginDescriptor getDeclaringPluginDescriptor() {
IPluginDescriptor cannot be resolved to a type
3. ERROR in /src/org/eclipse/core/internal/registry/ExtensionPointHandle.java
 (at line 29)
return RegistryCompatibilityHelper.getPluginDescriptor(getContributor().getName());
The method getPluginDescriptor(String) from the type RegistryCompatibilityHelper refers to the missing type IPluginDescriptor

1. ERROR in /src/org/eclipse/core/internal/registry/RegistryCompatibilityHelper.java
 (at line 14)
import org.eclipse.core.runtime.IPluginDescriptor;
The import org.eclipse.core.runtime.IPluginDescriptor cannot be resolved
2. ERROR in /src/org/eclipse/core/internal/registry/RegistryCompatibilityHelper.java
 (at line 37)
public synchronized static IPluginDescriptor getPluginDescriptor(String pluginId) {
IPluginDescriptor cannot be resolved to a type
3. ERROR in /src/org/eclipse/core/internal/registry/RegistryCompatibilityHelper.java
 (at line 47)
return (IPluginDescriptor) getPluginDescriptor.invoke(oldInternalPlatform, new Object[] {pluginId});
IPluginDescriptor cannot be resolved to a type

1. ERROR in /src/org/eclipse/core/runtime/IExtension.java
 (at line 180)
public IPluginDescriptor getDeclaringPluginDescriptor() throws InvalidRegistryObjectException;
IPluginDescriptor cannot be resolved to a type

1. ERROR in /src/org/eclipse/core/runtime/IExtensionPoint.java
 (at line 205)
public IPluginDescriptor getDeclaringPluginDescriptor() throws InvalidRegistryObjectException;
IPluginDescriptor cannot be resolved to a type

This is related to the fact that the class folder (classes) is passed as a source folder and a class folder to pde.build.
Comment 1 Olivier Thomann CLA 2010-11-02 13:18:47 EDT
Created attachment 182222 [details]
Proposed fix
Comment 2 DJ Houghton CLA 2010-11-02 15:55:23 EDT
Olivier, this patch does not apply cleanly in my workspace unless I reverse the patch. So just to be clear, you are changing the following line in the build.properties to be:
    source.runtime_registry_compatibility.jar = src/, classes/

And removing the customBuildCallbacks line and file?
Comment 3 Thomas Watson CLA 2010-11-02 15:59:20 EDT
Sorry DJ, I meant to report in this bug that I have released the patch to head.  Waiting for test build to complete.
Comment 4 Thomas Watson CLA 2010-11-02 16:01:59 EDT
Also note that I opened an API tooling bug329287 that shows up now if you checkout the code from head and have an API baseline of 3.6.x.
Comment 5 DJ Houghton CLA 2010-11-02 17:03:40 EDT
Is there an explanation as to why this just started failing recently in the builds?
Comment 6 Olivier Thomann CLA 2010-11-02 17:16:00 EDT
(In reply to comment #5)
> Is there an explanation as to why this just started failing recently in the
> builds?
I am trying to find out what has changed. So far, no luck.
Comment 7 Kim Moir CLA 2010-11-02 17:23:22 EDT
I updated to 3.7M3 bundles yesterday but we're not sure which bundle caused this issue to surface.
Comment 8 Kim Moir CLA 2010-11-02 17:28:25 EDT
btw, Tom your test build was succesful - no compile errors.
Comment 9 Thomas Watson CLA 2010-11-03 09:57:45 EDT
(In reply to comment #8)
> btw, Tom your test build was succesful - no compile errors.

Thanks.  I checked the build output from the test build and it is correct.  I also left the patch released for last nights build and confirmed that the org.eclipse.core.runtime.compatibility.registry bundle got build correctly and has the correct content.

I think the patch is a better way to build this bundle instead of the hack of using the classes/ folder as a source folder in the build.properties.
Comment 10 Olivier Thomann CLA 2010-11-09 13:14:29 EST
Should not this bug be closed as FIXED?
Comment 11 Thomas Watson CLA 2010-11-09 13:56:27 EST
(In reply to comment #6)
> (In reply to comment #5)
> > Is there an explanation as to why this just started failing recently in the
> > builds?
> I am trying to find out what has changed. So far, no luck.

Do we need a separate bug to track that?

(In reply to comment #10)
> Should not this bug be closed as FIXED?

See above.
Comment 12 Olivier Thomann CLA 2010-11-09 13:58:55 EST
(In reply to comment #11)
> Do we need a separate bug to track that?
yes.
Comment 13 Thomas Watson CLA 2010-11-09 16:05:34 EST
(In reply to comment #12)
> (In reply to comment #11)
> > Do we need a separate bug to track that?
> yes.

bug329853 opened.

Closing this bug as fixed.  The workaround has been released.  I call it a workaround, but it is likely a better, and less hacky, way to build this anyway.