Bug 32882 - [CVS UI] Bring back add tasks please
Summary: [CVS UI] Bring back add tasks please
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 2.1   Edit
Hardware: PC Windows 2000
: P3 normal with 1 vote (vote)
Target Milestone: 3.0 M2   Edit
Assignee: Platform-VCM-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: investigate
: 34553 (view as bug list)
Depends on:
Blocks:
 
Reported: 2003-02-25 00:32 EST by Fran Tonello CLA
Modified: 2003-06-16 21:08 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Fran Tonello CLA 2003-02-25 00:32:42 EST
When a new file is created in a CVS project, a new task used to get created to 
remind you that the file wasn't under version control.  This no longer works in 
the M5 and RC1 builds (and perhaps others).  It works fine in the official 
2.0.1 build.

This feature is described here in the RC1 build:
http://127.0.0.1:2058/help/index.jsp?
topic=/org.eclipse.platform.doc.user/tasks/tasks-100d.htm
Comment 1 Michael Valenta CLA 2003-02-25 10:24:18 EST
The use of tasks for added resources was removed intentionally. The doc should 
be updated. Changing title from "Auto task generation for unmanaged files is 
broken" to reflect required action.
Comment 2 Fran Tonello CLA 2003-02-25 14:37:27 EST
Why was this removed?  It was a VERY nice feature and seemed to work quite well!
Comment 3 Michael Valenta CLA 2003-02-25 14:53:35 EST
There were several holes that would have been very difficult to fix (i.e. 
markers were not properly removed in some cases). What did the markers provide 
you with that is not available using CVS decorators, Commit and/or synchronize?
(i.e. part of the reason they were removed is that the advantage to having them 
appeared to be a lot less then the effort to maintain them. It would be helpful 
to know what benefit they provided).
Comment 4 Fran Tonello CLA 2003-02-25 16:45:05 EST
The decorators are nice, but don't always show you everything.  What made me 
notice that auto task generation was gone in the first place was that the 
decorator on my project root told me that I had a difference in my workspace 
vs. CVS.  Upon investigation, I discovered that the difference was that my bin 
directory hadn't been ignored.  However, my bin directory was not showing in 
the explorer, hence there was no decorator to see.  Had auto task generation 
been there, I would've known immediately what the problem was.

Also, a task is much more noticable than a decorator and doesn't require the 
user to navigate all the way down to the new resource to see what's new, 
possibly having to eyeball-scan hundreds of files to find the new one.

Commit and Synchronize work, but for the former, the user might not want to 
Commit yet.  I actually found my problem by using Synchronize, but the task was 
much more convenient and had the elegant touch of having Quick Fixes that 
provided the exact CVS commands the user would want.

Would it be possible to just allow the user to manually delete the auto 
generated task in the case where something goes haywire and it doesn't get 
deleted automatically?  -It seems a real shame to throw out the baby with the 
bathwater here, especially since the haywire case is relatively rare.
Comment 5 Michael Valenta CLA 2003-03-12 09:15:49 EST
*** Bug 34553 has been marked as a duplicate of this bug. ***
Comment 6 Vincenz Braun CLA 2003-03-12 10:06:10 EST
Bring it back, please!
For me it is much more convenient than synchronization. Especially when
I want to add a folder to .cvsignore. Did'nt I have to deselect
all files under a directory when simply commiting? I sometimes only use
synchronization to check if there are changes. I do not like
to browse the whole tree to check for additions. I accidentally
added a whole build dir to the cvs because i did not see a task that
reminded me of the missing "build" resource that i would have added to
.cvsignore.

And there is more to update than the docs. It is shown in the
filter customization of the tasks view (CVS Add etc.). 
I really like to have all CVS
issues in the taks view. It is one of the features that i missed a lot
in other tools (and the reason i downloaded RC2 in the hope it was 
fixed!).

I think it is not a good idea to remove a feature some people really get
accustomed to only because it is hard to maintain.
Comment 7 Michael Valenta CLA 2003-03-18 16:34:57 EST
Changing title from "Auto task generation for unmanaged files is no longer done"
Comment 8 Fran Tonello CLA 2003-03-18 19:00:46 EST
Thanks for bringing this back!
Comment 9 Michael Valenta CLA 2003-03-19 09:10:36 EST
I didn't bring back the add tasks, I just reactivated the bug report. I'm not 
convinced that tasks are the right answer for this. We initially implemented 
them because we needed a way to show deleted resources and the navigator was 
unable to show them (it only shows resources that exist). However, given that 
it is rare that a single deletion is commited on it's own, it is probably a 
mistake to have a task that supports this.

I'm beginning to believe that the proper way to do this is to have a CVS 
Workspace View (a glorified Navigator view) that will show you the resources in 
your local workspace but allow you to specify filters for various CVS state 
information. Sample filters would be things like dirty (modified), questionable 
(added), deleted, merged with conflict, and ignored (there are probably more 
but that's all I can think of of the top of my head). In essence, this view is 
like the sync view except that it doesn't need to contact the server and the 
same menus that appear in other views would appear in this view.

I have marked this bug as one to investigate for 2.2
Comment 10 Fran Tonello CLA 2003-03-19 14:08:45 EST
I think an additional CVS Workspace View with filters is a good idea.  The 
great thing about a Task is that it's pro-active, though.  Perhaps the two 
could be integrated.  -The user could enable auto task generation which this 
theoretical CVS Workspace View could drive.  That would be really cool.

BTW, if it gets implemented, it would be nice to have this view available on a 
popup menu when right-clicking on the resource.  (Like Run and Run Unit Test, 
but that's another story!)  For example, the user could right-click on a 
project or package and see what source control thinks is dirty.
Comment 11 Jean-Michel Lemieux CLA 2003-06-16 21:08:04 EDT
See the new sync view. It will be in the next integration build. The view name
is Live Synchronize. It replaces add/delete tasks and the sync view.