Bug 327653 - [Dialogs] FilteredItemsSelectionDialog burns a lot of time in LinkedList#contains(..)
Summary: [Dialogs] FilteredItemsSelectionDialog burns a lot of time in LinkedList#cont...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 3.7 M3   Edit
Assignee: Markus Keller CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2010-10-13 08:14 EDT by Markus Keller CLA
Modified: 2011-10-06 03:50 EDT (History)
1 user (show)

See Also:

Attachments
Fix (2.59 KB, patch)
2010-10-13 08:14 EDT, Markus Keller CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2010-10-13 08:14:28 EDT 
Created attachment 180758 [details]
Fix

I20101012-0800

FilteredItemsSelectionDialog burns a lot of time in LinkedList#contains(..). This is mostly visible in real-life scenarios where e.g. Open Type has a full history (60 elements) and there are many matches.

In my runtime workspace (with a lot of garbage projects and a filled type history), this brings the match calculation time for "**" from 3.5s down to 0.7s.
Comment 1 Markus Keller CLA 2010-10-13 08:14:58 EDT 
Fixed in HEAD.
Comment 2 Markus Keller CLA 2010-12-07 11:53:15 EST 
Verified in I20101206-1800.
Comment 3 Dani Megert CLA 2011-10-06 03:50:11 EDT 
This didn't make it into the 4.x stream. Cherry-picked now:
Commit 74f04c211a0e6ad9851fd92ea3451501ddf011ff