Bug 326387 - [Workbench] PageLayout.addStandaloneViewPlaceholder(): ".standalonefolder" should be public API
Summary: [Workbench] PageLayout.addStandaloneViewPlaceholder(): ".standalonefolder" sh...
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.6   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2010-09-28 05:30 EDT by Marton Sigmond CLA
Modified: 2012-06-07 07:18 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marton Sigmond CLA 2010-09-28 05:30:29 EDT
Build Identifier: 20100617-1415

In order to place standalone view placeholders related to each other the refId needs to be used is: viewId + ".standalonefolder"

Example:
public void createInitialLayout(final IPageLayout layout) {
  layout.setEditorAreaVisible(false);

  layout.addStandaloneViewPlaceholder(View1.ID + ":*", IPageLayout.BOTTOM, 0.0f, layout.getEditorArea(), true);
  layout.addStandaloneViewPlaceholder(View2.ID + ":*", IPageLayout.BOTTOM, 0.5f, View1.ID + ":*.standalonefolder", true);
  layout.addStandaloneViewPlaceholder(View3.ID + ":*", IPageLayout.RIGHT, 0.5f, View2.ID + ":*.standalonefolder", true);
}

The ".standalonefolder" is internal (not even a constant).
Public API is needed to get the reference id of the placeholder.

Suggestion: the addStandaloneViewPlaceholder() method should return it.


Reproducible: Always

Steps to Reproduce:
Details here: http://www.eclipse.org/forums/index.php?t=msg&th=197409&start=0&S=5623800604b482188fd50180eaff4464
Comment 1 Marton Sigmond CLA 2010-09-28 05:32:48 EDT
Version changed from 4.1 to 3.6.
Comment 2 Paul Webster CLA 2011-01-31 09:20:53 EST
(In reply to comment #0)
> Example:
>   layout.addStandaloneViewPlaceholder(View1.ID + ":*", IPageLayout.BOTTOM,
> 0.0f, layout.getEditorArea(), true);
>   layout.addStandaloneViewPlaceholder(View2.ID + ":*", IPageLayout.BOTTOM,
> 0.5f, View1.ID + ":*.standalonefolder", true);


does "id:*.standalinefolder" work?  I'm surprised, as we wouldn't support more than one instance of a multi-instance view showing up in a standalone folder, at least not correctly.

I'll accept patches up to M6 (API freeze, 6 weeks) that return a useful relative-id and have a guard against stacking on a standalone view.

PW