Bug 32445 - Decorators - overupdating parent tree on "replace with latest"
Summary: Decorators - overupdating parent tree on "replace with latest"
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 2.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 2.1 RC2   Edit
Assignee: Jean-Michel Lemieux CLA
QA Contact:
URL:
Whiteboard:
Keywords: investigate
Depends on: 28343
Blocks:
  Show dependency tree
 
Reported: 2003-02-20 21:43 EST by Kevin McGuire CLA
Modified: 2003-03-05 16:24 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin McGuire CLA 2003-02-20 21:43:29 EST
1. start with a clean project
2. modify a file
=>Observe: parent directory tree becomes dirty

3. pick file, "Replace With->Latest"

=>Observe one round of item having label updated with clean label.  Note that 
this occurs while progress monitor is about 1/3 done.

=>Observe second round of CVS decorations disappearing/reappearing when 
progress monitor has completed

What's curious is that there is a definite delay between the CVS decorations 
being cleared and redrawn.  We should time this to see if we're taking a long 
time providing the decoration.
Comment 1 Kevin McGuire CLA 2003-02-20 21:49:18 EST
Actually, in the first Observe, it looks like the item gets updated without 
CVS decorations, then they appear at the end in a second wave.
Comment 2 Jean-Michel Lemieux CLA 2003-02-21 09:43:07 EST
turn off "compute deep check on folders" in the CVS decorators preference. The
icons still flash, but it happens a bit faster.

The problem is that the DecoratorManager unecessarily updates all views twice.
The first time the view returns and asks for a decoration and the
DecoratorManager returns that one is not available yet (this causes the decos to
dissapear). Once the decorator thread has updated, the decorations are re-applied.

IMHO, the first notification the DecoratorManager does is not required.
Comment 3 Jean-Michel Lemieux CLA 2003-02-21 10:00:29 EST
Depends on Bug 28343. Moving to UI.
Comment 4 Tod Creasey CLA 2003-02-21 10:06:53 EST
This will be fixed by Bug 32319 if it is approved.
Comment 5 Tod Creasey CLA 2003-02-21 10:08:03 EST
I meant Bug 28343
Comment 6 Tod Creasey CLA 2003-02-21 16:23:02 EST
This will be halved by the fix to Bug 28343. Team team to investigate further 
optimizations.
Comment 7 Jean-Michel Lemieux CLA 2003-03-05 16:24:01 EST
Mostly fixed by the UI decorator manager changes. The overupdated (e.g. flicker)
in the UI is now a problem with any lightweight decorator. Tod and I created a
test decorator that simply returned the original text and image for the
decorations and in the packages view there still was a flicker.

This is because of the notification scheme in the decorators.