Bug 323891 - [api][build] persist column sizes in Builds view
Summary: [api][build] persist column sizes in Builds view
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 enhancement (vote)
Target Milestone: 0.7   Edit
Assignee: Shawn Minto CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy
Depends on: 324259
Blocks:
  Show dependency tree
 
Reported: 2010-08-28 17:15 EDT by Steffen Pingel CLA
Modified: 2011-01-05 14:44 EST (History)
0 users

See Also:

Attachments
initial patch (42.88 KB, patch)
2010-09-01 13:38 EDT, Shawn Minto CLA 		no flags Details | Diff
mylyn/context/zip (97.46 KB, application/octet-stream)
2010-09-01 13:38 EDT, Shawn Minto CLA 		no flags Details
mylyn/context/zip (8.70 KB, application/octet-stream)
2010-09-01 17:05 EDT, Shawn Minto CLA 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steffen Pingel CLA 2010-08-28 17:15:12 EDT 
The size of the table columns is lost when the workbench is restarted. It would be nice if the columns were configurable and if the configuration was persisted.
Comment 1 Steffen Pingel CLA 2010-08-28 17:15:26 EDT 
Shawn, can you help out with that?
Comment 2 Steffen Pingel CLA 2010-08-28 17:15:49 EDT 
Also, sorting should be supported.
Comment 3 Shawn Minto CLA 2010-09-01 11:44:37 EDT 
I should be able to help with this.  We should also look at merging the Table and Tree viewer support that we have since there will be a lot of duplicated code.
Comment 4 Shawn Minto CLA 2010-09-01 13:38:19 EDT 
Created attachment 177988 [details]
initial patch

Steffen, here is an initial patch for adding this support and generalizing it from the TableViewerSupport.  It would be great if you could have a look over it.  Also, I need to do some testing still with the attachments table to make sure that I didn't break anything during the refactoring.
Comment 5 Shawn Minto CLA 2010-09-01 13:38:22 EDT 
Created attachment 177989 [details]
mylyn/context/zip
Comment 6 Steffen Pingel CLA 2010-09-01 13:46:07 EDT 
Looks great! The only suggestion I have is to make all methods and super classes of TableViewerSupport and TreeViewerSupport that are not accessed by client code package protected since they don't need to be API.
Comment 7 Shawn Minto CLA 2010-09-01 17:05:50 EDT 
I have changed all of the methods to be package protected or private for now.  This is now committed and we now have both table and tree support for column handling.
Comment 8 Shawn Minto CLA 2010-09-01 17:05:51 EDT 
Created attachment 178006 [details]
mylyn/context/zip
Comment 9 Steffen Pingel CLA 2010-09-01 22:12:46 EDT 
I have the impression that the changes broke sorting for attachments, e.g. sorting the attachments on Bug 315921 by creation date does not look right to me. Could you take a look?
Comment 10 Steffen Pingel CLA 2010-09-02 00:02:57 EDT 
I think this is fixed now. A return statement was missing where the sort column was determined. I simplified the code a bit using generics. Shawn, please check if that makes sense to you.

This is pretty cool stuff :).
Comment 11 Shawn Minto CLA 2010-09-02 11:18:36 EDT 
That looks great!  I don't know why I added some generics but not others ;)
Comment 12 Steffen Pingel CLA 2011-01-04 22:24:31 EST 
Marking patch obsolete as changes were committed to Mylyn Commons and not Mylyn Builds.