Bug 323781 - [build] provide UI for setting build parameters
Summary: [build] provide UI for setting build parameters
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 enhancement (vote)
Target Milestone: 0.7   Edit
Assignee: Eike Stepper CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks: 323568
  Show dependency tree
 
Reported: 2010-08-27 01:06 EDT by Steffen Pingel CLA
Modified: 2011-01-05 14:44 EST (History)
0 users

See Also:

Attachments
Patch v1 - crude ParametersDialog, functional (9.29 KB, patch)
2010-08-27 02:19 EDT, Eike Stepper CLA 		steffen.pingel: iplog+
Details | Diff
screenshot (21.23 KB, image/png)
2010-08-27 03:32 EDT, Steffen Pingel CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steffen Pingel CLA 2010-08-27 01:06:21 EDT 
If running plans requires additional parameters the user should be prompted to provide these (see bug 323568).
Comment 1 Eike Stepper CLA 2010-08-27 02:19:25 EDT 
Created attachment 177586 [details]
Patch v1 - crude ParametersDialog, functional
Comment 2 Eike Stepper CLA 2010-08-27 02:21:49 EDT 
I confirm that I'm the only author of the contributed patch and that I apply the EPL to this contribution.
Comment 3 Steffen Pingel CLA 2010-08-27 03:32:33 EDT 
Created attachment 177590 [details]
screenshot
Comment 4 Steffen Pingel CLA 2010-08-27 03:33:57 EDT 
Great stuff! I have applied the patch with minor changes to tweak the dialog a little bit.
Comment 5 Eike Stepper CLA 2010-08-27 04:13:20 EDT 
(In reply to comment #4)
> Great stuff! 

Thanks ;-)

> I have applied the patch with minor changes to tweak the dialog a
> little bit.

Yeah, the IParameterDefinition.description should be shown somewhere.

And the creation of the parameters Map in okPressed is also sub-optimal. Should use the parameter types and not the control types. Maybe we can move the whole value-handling into the implementations of IParameterDefinition...