Community
Participate
Working Groups
Eclipse M5, W2000 sp3. Compare the bottoms of the arguments tabs in the launchers of the Eclipse M4 and M5 builds. In M4, you have Radio button Local directory Radio button Workspace Checkbox Use default working directory But in M5, Workspace and Use default working directory are cut off and can therefore not be used. Screen grabs available. But where do I attach them? Or send them to?
Created attachment 3595 [details] Screen shots
Correction: It happens with M4 as well as M5. But not with 2.0.2. The good news is I have nailed it down - it only happens with large fonts. The way that tab resizes is possibly just assuming (hard-coded??) small fonts. Windows, Desktop|Properties|Settings|Advanced|Font Size, select either Small Fonts or Large Fonts. It might be worth also looking for where else similar resizing is done. Regards.
I can only cause the problem if I manually re-size the tab to be too short. However I can also manually re-size the tab larger again.
Via e-mail, "had no idea it was resizable. It is however strange that the default layout is too short". The dialog does re-size to show tabs headers (width), and is supposed to resize to height as required as well. However, It does not seem to expand to the proper height on the arguments tab.
I've seen similar problems on Linux-GTK in recent builds. The launch config dialog often opens too small to fit all the widgets.
It appears the width is re-sizing properly, but the height is not.
*** Bug 32747 has been marked as a duplicate of this bug. ***
Can duplicate by opening regular launch config dialog (not external tools), selecting local Java config type, making dialog very small, then clicking New. The Arguments tab is missing most of the working directory widgetry.
Fixed in LaunchConfigurationsDialog.resize(). Problem was that resizing was being done relative to the previous size of the entire edit area, instead of the size of just the old 'client area' of the tabbed folder (probably a result of launch config dialog refactoring). Thus, the new height wasn't accounting for the 'Name' field, the spacer, and the height of the tabs in the tabbed folder. Also increased the maximum allowable size of the dialog to be 90% of the available screen width & height (this had nothing to do with the bug, but just seems like a good idea).
Please verify, Jared.
Verified.
The 90% does not seem like a good idea. My launch dialog always opens huge (tall) now (since runtime workbench configs have a large source lookup path). I keep re-sizing it smaller, but it keeps opening larger than I want. I suggest we revert to the 70%.
The (new) user still needs to be made aware that the dialogue is resizable - by giving it a scroll bar maybe, or a different kind of border. Failing this there is no way of knowing that there is more data to be entered to make the launch work. On my machine the Local_directory, Workspace and Use_default_working_directory controls were not visible, and hence I had no idea they existed and needed attention.
These arguments should be visible with this fix - the problem is now that the dialog is too large. We do not intend to add a scroll area.
Fell back percentages to 70%.
Please verify.
*** Bug 34187 has been marked as a duplicate of this bug. ***
*** Bug 34196 has been marked as a duplicate of this bug. ***
*** Bug 34632 has been marked as a duplicate of this bug. ***
I saw my dialog become tall again. Re-opening to ensure we have "all" of the fix.
The max sixe constants actually size the tab area, rather than the dialog. Since there is a dialog surrounding the tab area, these constants are too large. For example, making a config with a classpath containing 46 projects causes the dialog to grow to the entire height of the screen (since the classpath tab requests to be 70% of the height, and the dialog has another 20- 30% of height). Reduced the constants to 50%. This behaves more friendly - the tab area only grows to half the size of the screen in the "worst" cases, and the surrounding dialog takes up an extra 20-30%. This is wide enough to display all tabs for all configs we have, and looks better. Fixed.
Please verify, Joe.
*** Bug 35045 has been marked as a duplicate of this bug. ***
Seems fine in RC3b
