Bug 323290 - FileDiffResult doesn't work with alternate Charsets
Summary: FileDiffResult doesn't work with alternate Charsets
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Compare (show other bugs)
Version: 3.5.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-Compare-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-20 15:24 EDT by Michael Valenta CLA
Modified: 2019-09-06 15:36 EDT (History)
0 users

See Also:

Attachments
Patch that fixes the problem (3.20 KB, patch)
2010-08-20 16:55 EDT, Michael Valenta CLA 		no flags Details | Diff
Updated patch with a test and a fix for an NPE (6.23 KB, patch)
2010-08-23 16:18 EDT, Michael Valenta CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Valenta CLA 2010-08-20 15:24:40 EDT 
When ReaderCreator was added to Compare/Core (see bug 263943), the refresh method in FileDiffResult was broken w.r.t alternate encodings since the utility method called to get the charset only knows about IEncodedStorage.
Comment 1 Michael Valenta CLA 2010-08-20 16:55:56 EDT 
Created attachment 177143 [details]
Patch that fixes the problem

I've attached a patch that fixes the issue. It would be good if we could get this into 3.6.x. If I have time in the next few days, I'll create a test case for this so we don't regress before the next chance I have to adopt the fix (i.e. we're on 3.5 now and I don't know when we'll be moving to 3.6).
Comment 2 Michael Valenta CLA 2010-08-23 16:18:24 EDT 
Created attachment 177262 [details]
Updated patch with a test and a fix for an NPE

I've added a test and fixed an NPE that was revealed by running the tests.
Comment 3 Eclipse Webmaster CLA 2019-09-06 15:36:18 EDT 
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.