Bug 322855 - New Query > Select a Repository wizard page should sort repositories by name
Summary: New Query > Select a Repository wizard page should sort repositories by name
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: Macintosh Mac OS X
: P3 enhancement (vote)
Target Milestone: 3.10   Edit
Assignee: Tomasz Zarna CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed, helpwanted
Depends on:
Blocks:
 
Reported: 2010-08-16 18:52 EDT by Lucas Panjer CLA
Modified: 2013-06-25 15:21 EDT (History)
2 users (show)

See Also:


Attachments
mylyn/context/zip (7.52 KB, application/octet-stream)
2013-06-17 17:19 EDT, Tomasz Zarna CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Panjer CLA 2010-08-16 18:52:54 EDT
The current sort, which appears to be grouped by connector type then alphabetically sometimes makes it difficult to find the repository you are looking for.

It would be easier to find repositories if there were sorted alphanumerically and not grouped by type.
Comment 1 Steffen Pingel CLA 2010-10-25 12:47:25 EDT
I would agree since the connector type is mostly a technical detail but not related to the user's view of configured repositories. As an example, if a project has a JIRA and Bugzilla tracker and they both have the same name prefix I would expect them to show up next to each other.

Mik, do you have any thoughts on changing the default sorting? We might need to add a preference since the change would be significant enough to potentially confuse users who are used to the current sorting.
Comment 2 Steffen Pingel CLA 2011-02-08 16:33:27 EST
I have put this on next week's meeting agenda to gather more input.
Comment 3 Sam Davis CLA 2012-08-22 18:27:48 EDT
Was anything decided about this? It might make sense to use the same order in other places that repositories are listed, e.g. the repositories dropdown in search currently sorts repositories alphabetically, but the sort is case sensitive, which is confusing.
Comment 4 Steffen Pingel CLA 2012-09-03 23:41:35 EDT
I don't recall if this was discussed. I have added this to the agenda for this week. Please feel free to join the call.
Comment 5 Steffen Pingel CLA 2012-09-13 20:39:55 EDT
We discussed this and while the current sorting strategy is reasonably obvious it seems more common in Eclipse to either provide categorized lists or sort items alphabetically. I have marked this bug as helpwanted to indicate that we'd be happy to resolve this request through a contribution.
Comment 6 GODFREY HOBBS CLA 2012-11-13 23:37:06 EST
Posted a review here:

https://git.eclipse.org/r/8676

The proposed change is to make sorting simple with string compareTo
Comment 7 GODFREY HOBBS CLA 2012-11-14 01:22:27 EST
This was fixed as part of a hackathon event and may appear a bit rushed.

The sorting of repository labels will be preformed by the the following method http://docs.oracle.com/javase/1.4.2/docs/api/java/lang/String.html#compareTo(java.lang.String)

compareToIgnoreCase is not used as this method does not appear to be used in other parts of the sorting.

It may be best to further investigate the removal of the class: TaskRepositoriesViewSorter.
Comment 8 Steffen Pingel CLA 2012-12-15 16:09:26 EST
Thanks for the proposed change! I have commented on the review.
Comment 9 Steffen Pingel CLA 2013-04-23 06:58:33 EDT
Godfrey, do you have time to take another pass through the change? Let me know if you have any questions about my comments on the review.
Comment 10 Steffen Pingel CLA 2013-05-17 01:43:45 EDT
Removing the milestone since we are getting close to the IP cut off.
Comment 11 Tomasz Zarna CLA 2013-06-17 17:18:23 EDT
Since Godfrey doesn't seem to be interested in working on this, I gave it a try: https://git.eclipse.org/r/#/c/13858/
Comment 12 Tomasz Zarna CLA 2013-06-17 17:19:06 EDT
Created attachment 232472 [details]
mylyn/context/zip
Comment 13 Sam Davis CLA 2013-06-25 12:56:51 EDT
Thanks very much for the contribution!