Bug 322689 - [resolver] stringVariablePresentation extension point requires impementation of internal interface
Summary: [resolver] stringVariablePresentation extension point requires impementation ...
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 4.3 M6   Edit
Assignee: Michael Rennie CLA
QA Contact:
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks:
 
Reported: 2010-08-13 16:36 EDT by Darin Wright CLA
Modified: 2013-02-21 16:27 EST (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Wright CLA 2010-08-13 16:36:40 EDT 
This looks like an oversight that has been around since 3.0:

The documentation for the extension point "org.eclipse.debug.ui.stringVariablePresentations" claims the extension must implement "org.eclipse.debug.ui.stringsubstitution.IArgumentSelector". However, there is no such interface. Instead there is an internal interface that is being used: "org.eclipse.debug.internal.ui.stringsubstitution.IArgumentSelector".

We should update to an API interface so contributors can actually implement without warning, but leave the old behind for compatibility.
Comment 1 Michael Rennie CLA 2012-02-28 16:50:21 EST 
This is a simple API change that we should (finally) correct.
Comment 2 Dani Megert CLA 2012-03-13 04:46:00 EDT 
Is this still on the radar? M6 is API freeze and due this week.
Comment 3 Michael Rennie CLA 2012-03-13 12:18:28 EDT 
This is by no means critical, it can wait (again).
Comment 4 Pawel Piech CLA 2013-02-13 12:13:11 EST 
Mike, do you still want to target this for 4.3?
Comment 5 Michael Rennie CLA 2013-02-21 16:27:14 EST 
Pushed fix to:

http://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=cc6a544e78dbb27322e50e3777b530edce3f8a36

I left the old interface and had it extend the new one, updated refs to the new interface.

commit for JDT debug:

http://git.eclipse.org/c/jdt/eclipse.jdt.debug.git/commit/?id=f030c76d59c5502b8e2419a2a610b58a7762e815