Bug 32166 - [rulers] Shift clicking in line number column doesn't select range
Summary: [rulers] Shift clicking in line number column doesn't select range
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 2.1   Edit
Hardware: PC Windows 2000
: P3 enhancement (vote)
Target Milestone: 3.4 M7   Edit
Assignee: Platform-Text-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2003-02-18 16:04 EST by Brian Howard CLA
Modified: 2008-04-23 11:45 EDT (History)
3 users (show)

See Also:

Attachments
Bug Fix (2.92 KB, patch)
2007-06-12 13:16 EDT, Nikolay Botev CLA 		no flags Details | Diff
Bug Fix (updated) (2.90 KB, patch)
2007-06-14 04:19 EDT, Nikolay Botev CLA 		no flags Details | Diff
Path against HEAD @ 2008-02-16 (2.71 KB, patch)
2008-02-16 03:11 EST, Nikolay Botev CLA 		no flags Details | Diff
Path against HEAD @ 2008-02-16 (2.71 KB, patch)
2008-02-16 03:12 EST, Nikolay Botev CLA 		no flags Details | Diff
Path against HEAD @ 2008-02-16 (2.71 KB, patch)
2008-02-16 03:16 EST, Nikolay Botev CLA 		no flags Details | Diff
Patch against HEAD @ 2008-02-16 (3.41 KB, patch)
2008-02-16 03:47 EST, Nikolay Botev CLA 		no flags Details | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Howard CLA 2003-02-18 16:04:52 EST 
When you click on a line number, the whole line will be selected. Now hold shift
and click on another line, and instead of selecting the range of lines only the
line clicked is selected. Shift clicking anywhere in the editor instead of in
the line number column on the second click works as expected.
Comment 1 Nikolay Botev CLA 2007-06-12 13:16:19 EDT 
Created attachment 71054 [details]
Bug Fix
Comment 2 Dani Megert CLA 2007-06-12 13:26:51 EDT 
Will look at the patch during 3.4.
Comment 3 Nikolay Botev CLA 2007-06-14 04:19:42 EDT 
Created attachment 71279 [details]
Bug Fix (updated)

more consistent with default (non-shift-down) behavior - the entire "start line" is selected.

Note: this is how visual studio ruler selection works. one thing vs.net does extra is switch to regular selection mode if the mouse is moved over the text while selecting, which enables partial line selection. this behavior is not implemented in this patch.
Comment 4 Dani Megert CLA 2007-10-23 03:27:29 EDT 
OK, looked a the patch: in my opinion it should not fully select the line with the current selection. At least that's what happens on the apps I tested.

Can you provide a new patch?
Comment 5 Dani Megert CLA 2007-10-23 06:28:17 EDT 
NOTE: you need to make the patch against HEAD as I just fixed bug 126365.
Comment 6 Nikolay Botev CLA 2008-02-16 03:11:00 EST 
Created attachment 89906 [details]
Path against HEAD @ 2008-02-16
Comment 7 Nikolay Botev CLA 2008-02-16 03:12:33 EST 
Created attachment 89907 [details]
Path against HEAD @ 2008-02-16
Comment 8 Nikolay Botev CLA 2008-02-16 03:16:09 EST 
Created attachment 89908 [details]
Path against HEAD @ 2008-02-16
Comment 9 Nikolay Botev CLA 2008-02-16 03:47:13 EST 
Created attachment 89909 [details]
Patch against HEAD @ 2008-02-16

Here is an updated patch that does not select the full line of the selection.

(Sorry for the extra activity, I was having Internet connection problems and did not realize I was uploading the same attachment multiple times)
Comment 10 Dani Megert CLA 2008-02-27 03:03:49 EST 
Will review during M7.
Comment 11 Dani Megert CLA 2008-04-23 11:35:40 EDT 
Thanks for the patch.
Fixed in HEAD (added your credentials to the copyright notice).
Available in builds > N20080422-2000.