Bug 321454 - org.eclipse.ui.part.EditorPart does not support super.setInput(null)
Summary: org.eclipse.ui.part.EditorPart does not support super.setInput(null)
Status: RESOLVED INVALID
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.6   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard:
Keywords: needinfo
Depends on:
Blocks:
 
Reported: 2010-08-01 05:46 EDT by Rekha CLA
Modified: 2010-08-25 01:42 EDT (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rekha CLA 2010-08-01 05:46:44 EDT 
Build Identifier: 3.6 - I20100507

API Compatibility between Eclipse 3.4/3.6 fails.

We (Datatools) used to do super.setInput(null); on editor dispose within our Editor implementation on Eclipse 3.4; however, Eclipse 3.6 does not support this anymore and this will fail. (org.eclipse.ui.part.EditorPart extension)

Reproducible: Always
Comment 1 Remy Suen CLA 2010-08-01 07:06:52 EDT 
Caused by bug 81514.
Comment 2 Dani Megert CLA 2010-08-02 03:54:15 EDT 
It is and was never legal to call it with 'null', so by the API rules the bug is on the client side. Can't you adapt your code?
Comment 3 Dani Megert CLA 2010-08-12 01:53:45 EDT 
Please answer the question.
Comment 4 Dani Megert CLA 2010-08-12 02:28:24 EDT 
Moving to data tools as the wrong code is there and has to be fixed there.
Comment 5 Brian Fitzpatrick CLA 2010-08-12 09:24:02 EDT 
Brian P - not sure if you can help get additional info gathered for this issue? But since it's with an editor part, it is most likely the SQL Editor (stab in dark with no additional details)...
Comment 6 Loic JULIEN CLA 2010-08-12 12:12:10 EDT 
(In reply to comment #3)
> Please answer the question.

Hi Dani,

I see that there were some answered questions here. Sorry about the delay.

1- This is not a Data Tools defects so this should not be under this component and should be moved back to its original assigment

2- We will investigate if we can adapt our code. We will get back to you shortly on this.

Thanks,
~Loic
Comment 7 Dani Megert CLA 2010-08-12 12:22:44 EDT 
>This is not a Data Tools defects
Well, comment 0 said otherwise ;-)
Comment 8 Loic JULIEN CLA 2010-08-12 12:28:49 EDT 
(In reply to comment #7)
> >This is not a Data Tools defects
> Well, comment 0 said otherwise ;-)

Thanks Dani for moving the defect back.

A quick clarification as I realize this is confusing. This call is being made our product code into the Eclipse base and the word Data Tools had been overloaded.

Thanks for your help on this,
~Loic
Comment 9 Dani Megert CLA 2010-08-25 01:42:31 EDT 
Marking as INVALID since there is no bug in Eclipse here.