Bug 321336 - [context][darktheme] Task Context Decorator should set highlight colour based on theme
Summary: [context][darktheme] Task Context Decorator should set highlight colour based...
Status: CLOSED MOVED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 minor with 8 votes (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: helpwanted
: 460623 473517 473738 (view as bug list)
Depends on:
Blocks: 493628
  Show dependency tree
 
Reported: 2010-07-30 08:58 EDT by oliver.burkhalter CLA
Modified: 2020-11-03 18:10 EST (History)
12 users (show)

See Also:


Attachments
Mylyn active task package explorer view with the colors (266.67 KB, image/jpeg)
2010-07-30 08:59 EDT, oliver.burkhalter CLA
no flags Details
Dark text on dark background in Package Explorer (51.25 KB, image/png)
2011-12-14 13:39 EST, David Biesack CLA
no flags Details
how eclipse i configured by means of decorator (181.43 KB, image/png)
2015-08-05 10:05 EDT, Alessandro Fardin CLA
no flags Details
project navigator pictures (399.71 KB, image/png)
2015-08-05 10:07 EDT, Alessandro Fardin CLA
no flags Details
Task Context Decorator ENABLED (40.80 KB, image/png)
2020-11-03 11:12 EST, maarten meijer CLA
no flags Details
Task Context Decorator DISABLED (42.45 KB, image/png)
2020-11-03 11:13 EST, maarten meijer CLA
no flags Details
mylyn/context/zip (2.90 KB, application/octet-stream)
2020-11-03 17:50 EST, maarten meijer CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description oliver.burkhalter CLA 2010-07-30 08:58:42 EDT
Build Identifier: 20100617-1415

If I activate a task and switch off the task-focused mode I see right the tree and the files and folders in the color light-gray. If a file is added to the task-context the color changes to black. But the contrast between light-gray and black is too weak on some monitors. See attached screenshot. In the Eclipse preferences "Colors and Fonts" I couldn't find any such settings.

It would be good, if you could define this highlight color for files which are in the task-context.

Reproducible: Always
Comment 1 oliver.burkhalter CLA 2010-07-30 08:59:54 EDT
Created attachment 175566 [details]
Mylyn active task package explorer view with the colors
Comment 2 Wayne B CLA 2010-08-18 17:54:26 EDT
I agree that this feature/bug is needed. I almost always have a task active to capture my file changes rather than having to assign them to a task before committing. I do not like the Focus option as it prevents me from browsing the hierarchy although sometimes it comes in handy to reopen files I had closed.

I would say at a minimum do not mess with the package name colors as I don't really see the point anyway.
Comment 3 Steffen Pingel CLA 2010-08-18 20:50:13 EDT
Thanks for the input. The light color indicates that an artifact is less interesting than artifacts that are rendered in the standard foreground color or in bold (landmarks). I believe the grey color is derived from the standard foreground color but I can see that there are use-cases for changing it.

I'll tentatively schedule this bug for 3.5 to investigate further.
Comment 4 Steffen Pingel CLA 2011-05-21 14:26:34 EDT
Unfortunately we didn't get around to this. Removing milestone for now but we'll consider it when planning the next release cycle.
Comment 5 David Biesack CLA 2011-12-14 13:39:12 EST
Created attachment 208400 [details]
Dark text on dark background in Package Explorer

I have Eclipse configured with a dark background and light foreground text.
The package explorer with Mylyn renders dark purple text on a black
background - this is unreadable. These are files in my current context.

Please make these colors configurable in Eclipse preferences.
Comment 6 Jo Inge Buskenes CLA 2013-10-06 15:39:20 EDT
I have the exact same problem as David, and it renders the task-focused project explorer view near useless in a dark themed Eclipse.
Comment 7 Sam Davis CLA 2014-09-16 12:59:57 EDT
Note that the decorator can be disabled: Preferences->General->Appearance->Label Decorations->Disable "Task Context Decorator"
Comment 8 Mathias Rühle CLA 2015-07-02 05:41:08 EDT
I use Eclipse with a dark theme, too. Thanks for the hint disabling the Task Context Decorator as a workaround.
Will the font color be configurable in a future release?
Comment 9 Sam Davis CLA 2015-07-06 13:47:57 EDT
I think it would be a good idea to set the highlight colour based on theme, as we now do for the notification popups.
Comment 10 Sam Davis CLA 2015-07-06 13:51:47 EDT
*** Bug 460623 has been marked as a duplicate of this bug. ***
Comment 11 Sam Davis CLA 2015-07-24 12:46:50 EDT
*** Bug 473517 has been marked as a duplicate of this bug. ***
Comment 12 Sam Davis CLA 2015-07-28 19:46:05 EDT
*** Bug 473738 has been marked as a duplicate of this bug. ***
Comment 13 Alessandro Fardin CLA 2015-07-30 05:34:43 EDT
(In reply to comment #7)
> Note that the decorator can be disabled: Preferences->General->Appearance->Label
> Decorations->Disable "Task Context Decorator"


Hi Sam, thank you for the suggestion about the configuration..
Comment 14 Alessandro Fardin CLA 2015-07-30 16:55:30 EDT
After having disabled Preferences->General->Appearance->Label Decorations->Disable "Task Context Decorator"

and after some work spent on eclipse 
the project explorer at some points shows unreadable text.

I'm using eclipse 4.5 CDT and mylyn 3.16
Comment 15 Sam Davis CLA 2015-07-30 17:13:03 EDT
Could you please post a screenshot showing unreadable text with the decorator disabled?
Comment 16 Alessandro Fardin CLA 2015-07-31 02:37:40 EDT
As soon as the issue will happen, I'll post a screenshot
Comment 17 Alessandro Fardin CLA 2015-08-05 10:05:24 EDT
Created attachment 255646 [details]
how eclipse i configured by means of decorator
Comment 18 Alessandro Fardin CLA 2015-08-05 10:07:22 EDT
Created attachment 255647 [details]
project navigator pictures

The issue of ureadable text on the project navigator is still present also if context decorator is disabled
Comment 19 Sam Davis CLA 2015-08-05 14:17:59 EDT
Thanks. I can see from your screenshot that there's no active task. Are you sure this is caused by Mylyn?
Comment 20 Alessandro Fardin CLA 2015-08-06 02:37:27 EDT
Yes, I'm almost sure,
I've deactivate the task in order to check if the project explorer text come back readable.
I and my team are using mylyn from 3 week ago and before using it we never experienced this behaviour.
This issue is not deterministic, some times happened, but when  it happens is always after activating a tasks.
Once it happens, the text in project explorer stays unreadable also after disabling the "focus on active task" in the project explorer .
The only way is to restart eclipse.

let me know if there are some logs things I can send you in order to investigate the problem
Comment 21 Sam Davis CLA 2015-08-06 12:59:18 EDT
Could you attach your Eclipse error log?
Comment 22 Przemysław Wróbel CLA 2017-05-31 05:00:19 EDT
I have the same problem when using dark themes - the navigator shows almost black file names on black background - this currently prevent me from using dark themes at all!
Comment 23 maarten meijer CLA 2020-11-03 11:12:07 EST
The Task Context Decorator not only sets the color to something poorly visible when using dark them, but it also changes the Font without allowing a preference for that font. Given that Eclipse 4.17 allows changing Tree and Table Font/Size (https://www.eclipse.org/eclipse/news/4.17/platform.php) having a decorator override a font setting in Tree or Table viewer without allowing it to be set with a preference is bad UI. At least read the font set in the pref and modify the color only, or allow a font to be set by the user.

I attach 2 images to deomstate problem on Mac
Comment 24 maarten meijer CLA 2020-11-03 11:12:50 EST
Created attachment 284650 [details]
Task Context Decorator ENABLED
Comment 25 maarten meijer CLA 2020-11-03 11:13:22 EST
Created attachment 284651 [details]
Task Context Decorator DISABLED
Comment 26 maarten meijer CLA 2020-11-03 14:41:34 EST
You can also set Hardware to All
Comment 27 maarten meijer CLA 2020-11-03 17:50:20 EST
Created attachment 284661 [details]
mylyn/context/zip

The font retrieved in the decorator is from CommonFonts and hence DefaultFont instead of the new Tree and Table Font Preference
Comment 28 maarten meijer CLA 2020-11-03 18:10:28 EST
The preference key is org.eclipse.ui.workbench.TREE_TABLE_FONT, not DEFAULT_FONT
Comment 29 Eclipse Webmaster CLA 2022-11-15 11:45:08 EST
Mylyn has been restructured, and our issue tracking has moved to GitHub [1].

We are closing ~14K Bugzilla issues to give the new team a fresh start. If you feel that this issue is still relevant, please create a new one on GitHub.

[1] https://github.com/orgs/eclipse-mylyn