Bug 32101 - JavaCompletionProcessor: error message never shown
Summary: JavaCompletionProcessor: error message never shown
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 2.1   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: 2.1 RC2   Edit
Assignee: JDT-Text-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-02-18 05:49 EST by Martin Aeschlimann CLA
Modified: 2003-03-03 13:25 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Aeschlimann CLA 2003-02-18 05:49:21 EST
form bug 31764 
The API says that an error message is shown when computeCompletionProposals or 
computeContextInformation return null, so only when no proposals are shown. 
However, teh current code does only return an error message when the number of 
corrections is > 0

public String getErrorMessage() {
	if (fNumberOfComputedResults == 0)
		return JavaUIMessages.getString
("JavaEditor.codeassist.noCompletions"); //$NON-NLS-1$
	if (PreferenceConstants.getPreferenceStore().getBoolean
(PreferenceConstants.CODEASSIST_FILL_ARGUMENT_NAMES)) {
		return fExperimentalCollector.getErrorMessage();
	} else {
		return fCollector.getErrorMessage();
	}
}
Comment 1 Philipe Mulet CLA 2003-02-18 08:37:32 EST
Currently the completion engine is never feeding the requestor (see bug 31764), 
I would not change this late in the 2.1 game (will defer completion engine fix 
for 2.1).
Comment 2 David Audel CLA 2003-02-26 11:23:37 EST
I have a fix for bug 31764. With this fix, an error is given to the code assist 
requestor when there is no completion and there is a non-syntax error. If this 
bug (32101)is not fixed, this error message will be never shown to the user.



Comment 3 Kai-Uwe Maetzel CLA 2003-03-03 13:25:17 EST
Build > 20020303.