Bug 31764 - CompletionEngine doesn't feed errors to completion requestor
Summary: CompletionEngine doesn't feed errors to completion requestor
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 2.1   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: 2.1 RC2   Edit
Assignee: David Audel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-02-13 07:24 EST by Philipe Mulet CLA
Modified: 2003-03-10 05:45 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philipe Mulet CLA 2003-02-13 07:24:24 EST 
Build 20030211

Looking at the problem factory defined in CompletionEngine constructor,
it appears not to forward errors to the requestor (since it overrides an
obsolete method).

Thus UI has no chance to display an informative message in case no completion 
was computed.

Need to investigate if we want to resurrect this behavior at this stage (is it 
causing grief to UI).

This feels like it got broken quite a while ago.
Comment 1 Philipe Mulet CLA 2003-02-13 12:42:08 EST 
SelectionEngine has same bug.

Behavior should be to filter out warnings and syntax errors (since heavy on 
recovery).

Need to ensure that UI is only displaying errors if no completion is available 
(or should we only feed errors if no completion is available). In this case we 
should only feed the first found error.
Comment 2 Philipe Mulet CLA 2003-02-18 04:54:22 EST 
Martin - do you have an opinion on this ? Currently your completion requestor 
will never get any error notification. By glancing at your implementation, it 
seems to only show errors if completions were available, which seems to be 
exactly the opposite of what we would expect.
Comment 3 Martin Aeschlimann CLA 2003-02-18 05:49:46 EST 
You're right, this looks wrong. I have no idea why this is there. Field bug 
32101 (jdt-text)
Comment 4 Philipe Mulet CLA 2003-02-18 08:37:58 EST 
Deferring, due to UI implication.
Post 2.1
Comment 5 Philipe Mulet CLA 2003-02-26 03:41:45 EST 
Reopening
Comment 6 David Audel CLA 2003-02-27 05:10:41 EST 
An error is given to the code assist requestor when there is no completion and 
there is a non-syntax error.

Fixed.
Comment 7 David Audel CLA 2003-03-10 05:45:21 EST 
Verified.