Bug 320895 - Consistency and stylability all gutters and margins in default stylesheet
Summary: Consistency and stylability all gutters and margins in default stylesheet
Status: RESOLVED WONTFIX
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 4.1   Edit
Hardware: All All
: P2 major (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords: usability
Depends on:
Blocks: 293481
  Show dependency tree
 
Reported: 2010-07-26 09:35 EDT by Dani Megert CLA
Modified: 2019-10-08 10:45 EDT (History)
6 users (show)

See Also:


Attachments
specs for gutters and margins (55.02 KB, image/png)
2010-08-16 17:23 EDT, Susan McCourt CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2010-07-26 09:35:53 EDT
SDK 4.0 - I20100722-2038.

The wider borders (especially those at the window border) reduce screen real-estate.
Comment 1 John Arthorne CLA 2010-07-26 13:06:32 EDT
In general this was a conscious design decision. See the following for some background discussion: http://dev.eclipse.org/blogs/kevinmcguire/2009/06/05/every-pixel-is-sacred-not-any-more/.

There might be some particular areas to improve on such as left/right window borders though. I believe these margins can actually be configured via CSS.
Comment 2 Susan McCourt CLA 2010-07-26 13:26:08 EDT
> In general this was a conscious design decision. See the following for some
> background discussion:
> http://dev.eclipse.org/blogs/kevinmcguire/2009/06/05/every-pixel-is-sacred-not-any-more/.

Yes.  Our story has been that the new default styling would add much more breathing room but we would maintain a way to get to "classic" spacing and hopefully make it easy to configure the default styling if space is the only issue.

> 
> There might be some particular areas to improve on such as left/right window
> borders though. I believe these margins can actually be configured via CSS.

The css files are in org.eclipse.platform/css

To change the margins you can tweak this (or delete it completely and you'll get 2 px around each edge by default)

.MTrimmedWindow.topLevel { 
    margin-top: 24px;
    margin-bottom: 2px;
    margin-left: 12px;
    margin-right: 12px;
}

One caveat is that you have to restart to get the new values.
We had originally hoped to do better in terms of dynamic/user friendly customization of the various themes, but didn't get there for 4.0.
Comment 3 Susan McCourt CLA 2010-08-16 15:30:08 EDT
Retitling this bug.
Two things to do here:
1) the gutters and margins in the default stylesheet are inconsistent.  The intention in the original visual design was that they be consistent.  This would actually result in larger gutters between tab stacks that match the larger margins on the outside.
2) Given that this bug was opened because the outside margins were considered too large, we need to ensure that all of the gutters and margins are styleable.
Comment 4 Susan McCourt CLA 2010-08-16 17:23:21 EDT
Created attachment 176739 [details]
specs for gutters and margins

here is what is being proposed by Linda (14 px margins and gutters)
Comment 5 Dani Megert CLA 2010-08-17 03:27:07 EDT
>2) Given that this bug was opened because the outside margins were considered
>too large, we need to ensure that all of the gutters and margins are styleable.
Please post in this bug where/what I have to change to make the margins smaller again. Good would be to keep the same values in one constant so that I only have to change it at one place.
Comment 6 Susan McCourt CLA 2010-08-17 15:54:11 EDT
(In reply to comment #5)
> >2) Given that this bug was opened because the outside margins were considered
> >too large, we need to ensure that all of the gutters and margins are styleable.
> Please post in this bug where/what I have to change to make the margins smaller
> again. Good would be to keep the same values in one constant so that I only
> have to change it at one place.

See the last part of comment 2 for what you have to do now to change the margins. This only affects outer margins.  This bug tracks making all gutters stylable.
Comment 7 Oleg Besedin CLA 2011-08-03 10:58:48 EDT
> The wider borders (especially those at the window border) reduce screen
> real-estate.

+1, I changed importance to "major".
Comment 8 Eclipse Genie CLA 2019-03-17 10:24:27 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 9 Lars Vogel CLA 2019-10-08 10:45:06 EDT
This bug was marked as stalebug a while ago. Marking as wontfix.

If this report is still relevant for the current release, please
reopen and remove the stalebug whiteboard tag.