Community
Participate
Working Groups
Using wikitext-to-eclipse-help ant task with markupLanguage="org.eclipse.mylyn.wikitext.tracwiki.core.TracWikiLanguage" doesn't handle [[Image(your_image_name]] properly. a href tag is created (not proper though) when img tag is supposed to be created.
Thanks for the bug. Images have not been implemented in /org.eclipse.mylyn.wikitext.tracwiki.core Please feel free to contribute a patch!
Just to let people know, I am working on a patch for this. I rather want this to work for the ShellEd project, you see. :-)
Thanks Mat, It's highly appreciated - I never managed to get back to it.
Can you also consider making ant tasks for trac wiki like the ones for mediawiki (e.g. mediawiki-to-eclipse-help). See http://help.eclipse.org/helios/index.jsp?topic=/org.eclipse.mylyn.wikitext.help.ui/help/Markup-Conversion.html
(In reply to comment #4) > Can you also consider making ant tasks for trac wiki like the ones for > mediawiki (e.g. mediawiki-to-eclipse-help). See > http://help.eclipse.org/helios/index.jsp?topic=/org.eclipse.mylyn.wikitext.help.ui/help/Markup-Conversion.html Yeah, I have considered it. I originally set out to make a doc plug-in that generates its contents in the same way that the Spec-File and Fedora-Packager plug-ins do. I came to this bug after peeling back the layers of what needs to be done to achieve that...
Hi, for initial feedback, I have attached a patch that now detects Trac wiki macros in the format of: [[MacroName]] or [[MacroName(arg1, arg2, ...)]] And processes the macros it knows and discards the macros it doesn't, which means it no longer attempts to make links where it shouldn't (it was previously mangling them horribly). It currently recognises one macro, the [[Image()]] macro and supports most of the macro's parameters. Current limitations are that it probably only works if the image in question is attached the same wiki page in which the macro appears, like this: [[Image(photo.jpg)]] or if the URL is spelled out in full like: [[Image(http://blah/photo.jpg)]] I will write some tests and submit those as a separate patch. But I would just like some feedback on this early version to make sure I'm going about things in the right way. Thanks! Mat
Created attachment 185605 [details] Image Macro Support
The patch looks great! A couple of things: * the percentage concept should apply for both height and width to ImageAttributes, and corresonding changes in HtmlDocumentBuilder * please provide some unit tests that exercise your code
Created attachment 186243 [details] mylyn/context/zip
(In reply to comment #8) > The patch looks great! A couple of things: > > * the percentage concept should apply for both height and width to > ImageAttributes, and corresonding changes in HtmlDocumentBuilder > * please provide some unit tests that exercise your code I was mistaken in my assumption that percentage values didn't apply to height (I couldn't get it to work in my browser, but after some reading it was probably because the image wasn't in a containing block.) I will address these points in the next version of the patch. Thanks very much for the feedback.
Created attachment 186342 [details] Patch to add image macro support to Trac wiki parser Updated patch. Now supports both widths and heights specified as percentages and now you may also put more than macro in the same paragraph.
Created attachment 186343 [details] Patch to add tests for Trac image macro support This patch adds tests for the previous patch.
Thanks for the great patch Mat! pushed changeset 6b601bfabd0a73b30abb0e61671809426912b0c2
Created attachment 186403 [details] mylyn/context/zip
reopening so that I can give credit to Mat for the patch
assigning to Mat for credit
