Bug 319469 - highlight filter matches in Task Search view
Summary: highlight filter matches in Task Search view
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: Macintosh Mac OS X
: P3 enhancement (vote)
Target Milestone: 3.5   Edit
Assignee: Kevin Sawicki CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed, noteworthy
Depends on:
Blocks:
 
Reported: 2010-07-10 15:22 EDT by Kevin Sawicki CLA
Modified: 2011-01-13 23:31 EST (History)
0 users

See Also:

Attachments
Proposed ui enhancements to Task Search (24.23 KB, image/png)
2010-07-10 15:25 EDT, Kevin Sawicki CLA 		no flags Details
Patch to highlight filter matches (10.23 KB, patch)
2010-07-10 15:31 EDT, Kevin Sawicki CLA 		no flags Details | Diff
Second Patch to highlight filter matches (10.70 KB, patch)
2010-07-10 15:44 EDT, Kevin Sawicki CLA 		steffen.pingel: iplog+
Details | Diff
mylyn/context/zip (9.52 KB, application/octet-stream)
2010-07-15 17:56 EDT, Steffen Pingel CLA 		no flags Details
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Sawicki CLA 2010-07-10 15:22:17 EDT 
Matches to the filter text in the Task Search view should be highlighted
similarly to the File Search view matches.

This would make it easier to see the matches of the filter in the displayed
task summary.
Comment 1 Kevin Sawicki CLA 2010-07-10 15:25:45 EDT 
Created attachment 173946 [details]
Proposed ui enhancements to Task Search

Highlights matches to filter text.
Comment 2 Kevin Sawicki CLA 2010-07-10 15:31:00 EDT 
Created attachment 173948 [details]
Patch to highlight filter matches

Patch to use a new label provider that decorates matches to the filter pattern entered in the search view.
Comment 3 Kevin Sawicki CLA 2010-07-10 15:32:02 EDT 
The patch attached uses the same look and feel for highlighted matches as the file search page.
Comment 4 Kevin Sawicki CLA 2010-07-10 15:44:46 EDT 
Created attachment 173949 [details]
Second Patch to highlight filter matches

Updated patch that preserves font and foreground/background colors from wrapped SearchResultsLabelProvider.
Comment 5 Steffen Pingel CLA 2010-07-11 00:20:46 EDT 
Thanks for the patch. That is cool. I'll try to review next week.
Comment 6 Steffen Pingel CLA 2010-07-15 17:51:42 EDT 
I have applied the patch. The only modification I made was to keep the original copyright header from DecoratingFileSearchLabelProvider and add Perforce in the contributors section since it appeared that RepositorySearchStyledLabelProvider is largely based on that. Could confirm that Kevin? If it was written from scratch I'd be happy to change the copyright header accordingly.
Comment 7 Kevin Sawicki CLA 2010-07-15 17:55:47 EDT 
Yes, that was the base of the code, I only did some minor re-formatting and re-organization of logic.
Comment 8 Steffen Pingel CLA 2010-07-15 17:56:44 EDT 
Thanks. Looks like we are done here.
Comment 9 Steffen Pingel CLA 2010-07-15 17:56:46 EDT 
Created attachment 174456 [details]
mylyn/context/zip