Bug 31940 - Reconciler may not disable old feature versions depending on order of comparison
Summary: Reconciler may not disable old feature versions depending on order of comparison
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Update (deprecated - use Eclipse>Equinox>p2) (show other bugs)
Version: 2.0.2   Edit
Hardware: PC Windows 2000
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Christophe Elek CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-02-15 10:24 EST by Steve Francisco CLA
Modified: 2003-02-21 07:53 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Francisco CLA 2003-02-15 10:24:25 EST 
If there are multiple versions of a feature present, and a new workspace is 
started, the reconciler does an optimistic approach of enabling all, then 
seeing what should be disabled.  It disables/removes old versions when 
detected.  However the problem is that the test for this is dependent on the 
order that they are compared.

For example, if you have version 1.0.0 and 1.0.1 of a feature, the test says:
    if (1.0.1 > 1.0.0) then remove 1.0.0
which works, but if compared in the other order,
    if (1.0.0 > 1.0.1) then remove 1.0.1
which fails because the if-test is false, and 1.0.0 is never removed.

The comparison should take into account the situation where the first operand 
is the smaller one.
Comment 1 Dejan Glozic CLA 2003-02-15 10:27:52 EST 
Just curious - how did you find out about what the reconciler does in detail :-
)?
Comment 2 Christophe Elek CLA 2003-02-15 10:36:47 EST 
Action Taken:
After calculating top features the reconciler attemtps to remove duplicates. 
the algorithm had a flaw if the last item in the top feature was the highest
version.
Fixed.
Steve said it fixed his problem
Action Plan: test and include in 2.1

PS: I told Steve to open the bug and I told him what was happening...
Comment 3 Christophe Elek CLA 2003-02-21 07:53:49 EST 
Fixed in 2.0.3 and 2.1