Bug 31914 - [CVS Core] refresh local does not update dirty state of parent folders
Summary: [CVS Core] refresh local does not update dirty state of parent folders
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 2.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 2.1.1   Edit
Assignee: Michael Valenta CLA
QA Contact:
URL:
Whiteboard:
Keywords: readme
: 33619 35716 (view as bug list)
Depends on:
Blocks:
 
Reported: 2003-02-14 16:04 EST by Jean-Michel Lemieux CLA
Modified: 2003-06-02 11:41 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jean-Michel Lemieux CLA 2003-02-14 16:04:45 EST 
To reproduce:
1. checkout a project to your workspace
2. add a file
3. project and file show up as dirty
4. open file explorer
5. delete the file
6. return to eclipse and refresh local the project
7. the file is deleted but the dirty state for the project and/or parent folders
is not updated.

I think the problem is that the toggling of dirty states for parent folders is
handled in the MoveDeleteHook class but when a file has already been deleted
from the file system this hook is no called. Remember that the hook should _not_
be called since the file has already been deleted and there is no action to veto.
Comment 1 Jean-Michel Lemieux CLA 2003-02-28 17:35:32 EST 
This bug will result in the deletion not showing as an outgoing deletion. As a 
workaround, refresh from file system than after synchronizing with the
repository run override and update to get the file back.

Moving to post 2.1.
Comment 2 Jean-Michel Lemieux CLA 2003-03-02 20:29:32 EST 
*** Bug 33619 has been marked as a duplicate of this bug. ***
Comment 3 Michael Valenta CLA 2003-03-26 11:48:55 EST 
*** Bug 35716 has been marked as a duplicate of this bug. ***
Comment 4 Michael Valenta CLA 2003-04-14 15:57:01 EDT 
We should investigate how complex the fix is for this for 2.1.1. I have a 
feeling that it will be too compex but it's worth looking at.
Comment 5 Michael Valenta CLA 2003-04-15 08:02:32 EDT 
I retract my last statement. Unless I am mistaken, this should be easy to fix. 
It should be enough to flush whatever sync info we have (in the 
SyncFileChangeListener) which will cause it to be re-read from disk. We can 
limit when we flush by doing so only on file deletions where the file is not 
managed (because the sync info was lost) but the parent folder is a CVS folder.
Comment 6 Michael Valenta CLA 2003-04-22 11:01:15 EDT 
Fix has been released to R2_1_maintenance branch
Comment 7 Jean-Michel Lemieux CLA 2003-06-02 11:41:15 EDT 
Verified.