Bug 318914 - [WorkingSets] Provide a preference to set size of the list of most recently used working sets
Summary: [WorkingSets] Provide a preference to set size of the list of most recently u...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.6   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 3.7 M6   Edit
Assignee: Oleg Besedin CLA
QA Contact: Oleg Besedin CLA
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks:
 
Reported: 2010-07-05 11:51 EDT by Hitesh CLA
Modified: 2011-10-06 05:28 EDT (History)
7 users (show)

See Also:

Attachments
Patch V01 (4.38 KB, patch)
2010-07-05 11:51 EDT, Hitesh CLA 		no flags Details | Diff
Patch (17.71 KB, patch)
2011-03-02 16:49 EST, Oleg Besedin CLA 		no flags Details | Diff
Patch (4.46 KB, patch)
2011-03-04 14:36 EST, Oleg Besedin CLA 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hitesh CLA 2010-07-05 11:51:06 EDT 
Created attachment 173449 [details]
Patch V01

Provide a preference to set the size of the list of most recently used working sets as . Attached is a potential patch.
Comment 1 Oleg Besedin CLA 2011-03-02 16:49:39 EST 
Created attachment 190210 [details]
Patch

The patch adds the following APIs:
IWorkingSetManager#
	public void setRecentWorkingSetsLength(int length);
	public int getRecentWorkingSetsLength();

(The IWorkingSetManager is marked as "no implement" and got a new method last time in 3.4.)

The patch exposes new MRU preference in the General -> Workspace preference page.

The patch adds JUnit IWorkingSetManagerTest№testRecentWorkingSetsLength().

If anybody want to review the patch, please do it soon so we can make the change in time for M6.
Comment 2 Dani Megert CLA 2011-03-04 07:55:53 EST 
Oleg, I think the bug was wrongly filed by Hitesh. The client only requested API to change the size/limit of recently used working sets. Having said that, if Platform UI thinks it makes sense to also add UI for that, OK. However, the 'Workspace' page is wrong as that page should only contain workspace and not workbench (i.e. UI) related things.

"Show up to this number of recent working sets:" sounds a bit sloppy to me - but I'm not a native speaker.
Comment 3 Oleg Besedin CLA 2011-03-04 14:36:13 EST 
Created attachment 190434 [details]
Patch

Updated patch:
- removed UI preferences page
- changed MRU preference to be shown via IWorkbenchPreferenceConstants.RECENTLY_USED_WORKINGSETS_SIZE
Comment 4 Oleg Besedin CLA 2011-03-04 14:40:45 EST 
Patch applied to CVS Head. Thanks to all people who helped!
Comment 5 Oleg Besedin CLA 2011-03-08 10:04:28 EST 
Verified that new IWorkingSetManager APIs are present and functioning in the I20110307-2110.
Comment 6 Dani Megert CLA 2011-10-06 05:27:57 EDT 
Oleg, I reopen this bug as it is not included in R4_development. Not sure whether this is not needed in 4.x or whether this just got lost.
Comment 7 Dani Megert CLA 2011-10-06 05:28:51 EDT 
(In reply to comment #6)
> Oleg, I reopen this bug as it is not included in R4_development. Not sure
> whether this is not needed in 4.x or whether this just got lost.

Sorry, I meant to reopen another bug.