Bug 31806 - Replace with Latest Does Not Reset Changed Decorator
Summary: Replace with Latest Does Not Reset Changed Decorator
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Team (show other bugs)
Version: 2.1   Edit
Hardware: PC Windows 2000
: P2 major (vote)
Target Milestone: 2.1 RC3   Edit
Assignee: Jean-Michel Lemieux CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-02-13 14:11 EST by JJ CLA
Modified: 2003-03-12 12:32 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description JJ CLA 2003-02-13 14:11:46 EST
This is with M5.

The decorator appears on a folder of files.  I team replace with latest from
repository.  The decorator does not disappear.
Comment 1 JJ CLA 2003-02-13 14:49:35 EST
Turning prune empty directories off and then replacing with latest turns the
decorators off.

Looks like bug 29413
Comment 2 Jean-Michel Lemieux CLA 2003-02-14 16:44:33 EST
I'm pretty sure this has been fixed post-M5. Also, as a result of changes made
to fix Bug 29944, several other decorators issues have been addressed.

I'll keep open until all decorator changes have been released and you give me
the ok.
Comment 3 Jean-Michel Lemieux CLA 2003-02-17 22:37:39 EST
Fixes have been released to HEAD - they will be in tomorrow's integration build.
Comment 4 JJ CLA 2003-02-24 15:13:58 EST
I just downloaded RC1.  This is still not fixed.  
Comment 5 JJ CLA 2003-02-24 16:28:59 EST
Hmm...  now I am seeing something in the cvs console.  Seems my problem is
related to my other bug 31820.

I get 
Error: project-name: cvs server: cannot open directory
/cvs/modules/src/DirectoryOne: No such file or directory
***
Comment 6 Michael Valenta CLA 2003-02-25 12:18:33 EST
Reopening to reinvestigate in relation to bug 31820
Comment 7 JJ CLA 2003-02-27 19:15:11 EST
So I deleted the folder that was giving this error and then went to the cvs
repository and checked it out again into the correct spot.  I no longer get the
can not open directory error in the cvs console but the decorator still shows it
as being modified.

Compare with latest from repo says there are no differences.
Comment 8 JJ CLA 2003-02-27 21:13:16 EST
Hmmm tried turning the prune empty directories off but that no longer removes
the decorator.  
Comment 9 Jean-Michel Lemieux CLA 2003-03-03 14:13:49 EST
The decorators were cached for folders and there was no way to clear the cache
if the calculation was wrong. In the next integration build I20030304 this
problem should be fixed.

Get the new build and turn off/on decorators to verify.
Comment 10 JJ CLA 2003-03-10 15:20:16 EST
I am using RC2 and I turned off the decorators and turned them back on via
window->pref->labeldecorators->[uncheck cvs, apply], waited for the decorators
to be not shown and then checked cvs, apply and the decorators came back.  The
changed decorator still shows up despite there being no differences between the
souce tree and the local copy.  No errors are printed in the cvs console.
Comment 11 Michael Valenta CLA 2003-03-11 11:09:13 EST
If you perform a Team>Synchronize with Repository, does the operation report 
that your workspace matches the server?
Comment 12 JJ CLA 2003-03-11 13:20:53 EST
Yeah that's correct.  It says "Workspace resources are the same as remote" in
the Nothing to Synchronize Dialog box.
Comment 13 Jean-Michel Lemieux CLA 2003-03-12 12:32:32 EST
Found yet another problem with deleted folders (a.k.a pruned folders). In some
cases a phantom folder without CVS folder information. We've fixed the
isModified() method on EclipseFolder to ignore non-existing folders that don't
have CVS folders. 

This fixes another problem that would occur on disconnect. If you disconnect and
reconnect all existing folders that have phantom children would be marked as dirty.

fix released to HEAD and will be in RC3. Again, and again :) :)