Bug 317771 - FUP of 315978: Add performance tracking test for scenario fixed by bug# 315978
Summary: FUP of 315978: Add performance tracking test for scenario fixed by bug# 315978
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.6.2   Edit
Assignee: Satyam Kandula CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 322325
Blocks:
  Show dependency tree
 
Reported: 2010-06-24 00:05 EDT by Srikanth Sankaran CLA
Modified: 2011-01-20 05:03 EST (History)
5 users (show)

See Also:

Attachments
Patch for the Performance test (44.87 KB, patch)
2010-06-24 02:51 EDT, Satyam Kandula CLA 		no flags Details | Diff
Patch for the Performance test (44.87 KB, patch)
2010-06-25 08:49 EDT, Satyam Kandula CLA 		no flags Details | Diff
Patch for 3.6 Maintenance (45.94 KB, patch)
2011-01-11 10:57 EST, Satyam Kandula CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Srikanth Sankaran CLA 2010-06-24 00:05:36 EDT 
We need to add a test case to the performance test suite
that covers the scenario fixed by bug# 315978.

A program that generates the test case similar to the reported
supplied test case is available in bug# 315978 comment# 24.

Satyam, please follow up.
Comment 1 Satyam Kandula CLA 2010-06-24 02:51:42 EDT 
Created attachment 172571 [details]
Patch for the Performance test

Frederic, 
Incorporated the copyright as per your instructions. Please look at the copyright to be sure that it is good and correct.
Comment 2 Frederic Fusier CLA 2010-06-25 03:30:13 EDT 
(In reply to comment #1)
> Created an attachment (id=172571) [details]
> Patch for the Performance test
> 
> Frederic, 
> Incorporated the copyright as per your instructions. Please look at the
> copyright to be sure that it is good and correct.

Patch looks good to me. However, there's a typo in EclipseVisitorBug.java. The copyright comment ends with two slash, hence you get a compiler error while running the test. Please fix it.

Also, I would like to have a preview of times in R3_6_maintenance and on top of 3.6.0 (v_A58) to have an idea of what is the fix perf improvement. Could you put some numbers before we release the patch? TIA
Comment 3 Satyam Kandula CLA 2010-06-25 08:47:12 EDT 
(In reply to comment #2)
Frederic, Thanks for your comments. I will fix the copyright. 

Without the patch it takes 1.6 minutes and with the patch it takes around 1.5 seconds.
Comment 4 Satyam Kandula CLA 2010-06-25 08:49:28 EDT 
Created attachment 172740 [details]
Patch for the Performance test

Fixed the copyright typo!
Comment 5 Frederic Fusier CLA 2010-06-25 08:54:09 EDT 
Great :-)
Hence, +1 for the patch
Comment 6 Satyam Kandula CLA 2010-07-01 05:21:49 EDT 
Released in HEAD and perf_36x
Comment 7 Jay Arthanareeswaran CLA 2010-08-27 03:20:04 EDT 
Verified for 3.6.1 RC2 by code inspection.
Comment 8 Frederic Fusier CLA 2010-08-27 04:32:40 EDT 
(In reply to comment #7)
> Verified for 3.6.1 RC2 by code inspection.

I disagree, this test was not released in R3_6_maintenance branch. It was released in perf_36x branch which is the branch for the 3.6 baseline and which is used for 3.7 performance tests.
Comment 9 Frederic Fusier CLA 2010-08-27 04:35:55 EDT 
To be backported for 3.6.1, the patch needs to be released both in R3_6_maintenance branch *and* perf_35x (which is the branch for the baseline of 3.6 performance tests...).
Comment 10 Frederic Fusier CLA 2010-08-27 04:38:07 EDT 
Note also that this test has an invalid duration in HEAD stream, hence
bug 322325 needs to be fixed before releasing this test into R3_6_maintenance stream...
Comment 11 Srikanth Sankaran CLA 2010-08-27 05:37:30 EDT 
(In reply to comment #9)
> To be backported for 3.6.1, the patch needs to be released both in
> R3_6_maintenance branch *and* perf_35x (which is the branch for the baseline of
> 3.6 performance tests...).

Frederic, good catch. Please proceed with releasing the patch
appropriately for the 3.6 branch. This is  already targetted
for and has a +1 for 3.6.1 backport -- Thanks!
Comment 12 Frederic Fusier CLA 2010-08-27 05:45:45 EDT 
(In reply to comment #11)
> (In reply to comment #9)
> > To be backported for 3.6.1, the patch needs to be released both in
> > R3_6_maintenance branch *and* perf_35x (which is the branch for the baseline of
> > 3.6 performance tests...).
> 
> Frederic, good catch. Please proceed with releasing the patch
> appropriately for the 3.6 branch. This is  already targetted
> for and has a +1 for 3.6.1 backport -- Thanks!

I will take care of this as well as for bug 322325...

I also change the target to 3.6.2 as bug 315978 was manually verified (by me), hence there's no real urgency for 3.6.1...
Comment 13 Frederic Fusier CLA 2010-12-27 03:52:29 EST 
Satyam,

Unfortunately, I won't have time to look at this test, hence I put it back to you...
Comment 14 Dani Megert CLA 2011-01-11 07:29:32 EST 
ping! This is targeted for 3.6.2 and we have RC1 this week.
Comment 15 Olivier Thomann CLA 2011-01-11 08:28:32 EST 
Satyam, could you please add the test for tomorrow's M-build.
Thanks.
Comment 16 Satyam Kandula CLA 2011-01-11 10:57:30 EST 
Created attachment 186515 [details]
Patch for 3.6 Maintenance

Modified the build.properties also accordingly.
Comment 17 Olivier Thomann CLA 2011-01-11 11:09:29 EST 
+1.
Comment 18 Satyam Kandula CLA 2011-01-11 23:58:16 EST 
Released on 3.6 maintenance branch and perf_35x branch
Comment 19 Ayushman Jain CLA 2011-01-20 05:03:35 EST 
Verified for 3.6.2 using code inspection