Bug 316282 - [relengtool] Opening context menu can take several seconds due to releng tool
Summary: [relengtool] Opening context menu can take several seconds due to releng tool
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 3.6   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: 3.7 M1   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks: 260684
  Show dependency tree
 
Reported: 2010-06-09 08:46 EDT by Dani Megert CLA
Modified: 2010-06-10 01:52 EDT (History)
0 users

See Also:

Attachments
Fix (37.81 KB, patch)
2010-06-09 08:47 EDT, Dani Megert CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2010-06-09 08:46:09 EDT 
3.6 RC4 but also in previous releases.

1. have workspace with many projects, at least one shared and one map file 
   project
2. observe: context menu opens instantaneous
3. on a shared project do: context menu > Compare With > Released
4. repeat step 3
   ==> it can take several seconds until the context menu is opened

This is caused by very expensive isEnabled() computation in 'CompareLocalToMap' and 'ReplaceLocalFromMap'.
Comment 1 Dani Megert CLA 2010-06-09 08:47:58 EDT 
Created attachment 171519 [details]
Fix

This fix drastically improves the performance and also fixes several issues like not removing resource listeners or not disposing the MapProject.
Comment 2 Dani Megert CLA 2010-06-09 12:23:54 EDT 
Fixed in HEAD.