Bug 315039 - [patch] Eclipse launch configuration should inherit properties from target platform
Summary: [patch] Eclipse launch configuration should inherit properties from target pl...
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.6   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.8 M6   Edit
Assignee: Curtis Windatt CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2010-05-31 04:30 EDT by Gunnar Wagenknecht CLA
Modified: 2012-02-29 16:41 EST (History)
2 users (show)

See Also:

Attachments
patch to inherit properties when launching default app (2.48 KB, patch)
2010-05-31 04:45 EDT, Gunnar Wagenknecht CLA 		no flags Details | Diff
patch (2.80 KB, patch)
2010-09-23 11:24 EDT, Gunnar Wagenknecht CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gunnar Wagenknecht CLA 2010-05-31 04:30:48 EDT 
When creating a new Eclipse launch configuration from a target platform not containing products but an application PDE correctly recognizes the default application. However, due to the fix for bug 175437 all config.ini properties inherited from the target platform are cleared during launching.

My observation is that this fix is too drastic. The requirement in bug 175437 only talks about the splash screen. In this case the products indeed don't match.

However, I have a case where I create a new Eclipse launch config based on an
Eclipse application from my target platform. PDE correctly recognizes the
application in config.ini and sets the proper default application to launch. However, because of this fix other important properties are not copied.
Comment 1 Gunnar Wagenknecht CLA 2010-05-31 04:45:26 EDT 
Created attachment 170495 [details]
patch to inherit properties when launching default app

The attached patch adds an additional check to not clear properties when launching the default application but only when no product is launched.
Comment 2 Gunnar Wagenknecht CLA 2010-05-31 04:46:20 EDT 
This should be a 3.6.1 candidate. PDE team please remove target milestone if you think it shouldn't.
Comment 3 Curtis Windatt CLA 2010-08-10 11:04:44 EDT 
Moving to 3.7, this is not a regression (or at least not a recent one).
Comment 4 Gunnar Wagenknecht CLA 2010-09-23 11:24:38 EDT 
Created attachment 179467 [details]
patch

Revised patch while working on bug 326059.
Comment 5 Jeff McAffer CLA 2010-12-13 10:03:49 EST 
This seems pretty reasonable.  Basically the original changes assumed that product extensions were being used.  If just applications are being used we should have some similar behaviour.
Comment 6 Curtis Windatt CLA 2012-02-29 16:41:37 EST 
Yes, this change is quite reasonable.  Sorry that it's been left for so long.  Never enough committer time to go around :) Pushed the fix to master.