Bug 175437 - [Regression] Eclipse SDK splash screen appears in hello RCP template
Summary: [Regression] Eclipse SDK splash screen appears in hello RCP template
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3 M6   Edit
Assignee: PDE-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-02-24 23:41 EST by Wassim Melhem CLA
Modified: 2010-06-01 01:48 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wassim Melhem CLA 2007-02-24 23:41:55 EST 
3.3M5

1. Create a Hello RCP template
2 Launch it

the Eclipse SDK splash screen appears.  It must not.

An RCP application that has no product associated with it does not show a splash screen.
Comment 1 Brian Bauman CLA 2007-02-26 09:24:12 EST 
It wasn't me (atleast I think so).  I have not touched the launcher since I was banned from it.
Comment 2 Wassim Melhem CLA 2007-02-26 10:14:21 EST 
The regression was introduced before the ban, which is still in effect btw.
Comment 3 Wassim Melhem CLA 2007-02-27 00:38:50 EST 
Fixed.

Values from target config.ini are copied as-is ONLY IF we are launching a product that is equal to the one specified in the target config.ini
Comment 4 Gunnar Wagenknecht CLA 2010-05-31 04:15:17 EDT 
(In reply to comment #3)
> Fixed.
> 
> Values from target config.ini are copied as-is ONLY IF we are launching a
> product that is equal to the one specified in the target config.ini

My observation is that this fix is too drastic. The requirement only talks about the splash screen which appears in RCP templates. In this case the products indeed don't match.

However, I have a case where I create a new Eclipse launch config based on an Eclipse application from my target platform. PDE correctly recognizes the application in config.ini and sets the proper defaults. However, because of this fix other important properties are not "copied".

Should I re-open this one or create a new bug?
Comment 5 Darin Wright CLA 2010-05-31 15:06:28 EDT 
(In reply to comment #4)
> Should I re-open this one or create a new bug?

Please open a new bug.