Bug 312216 - [WorkbenchParts] Wokbench.saveAll does not save non-part saveables
Summary: [WorkbenchParts] Wokbench.saveAll does not save non-part saveables
Status: NEW
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.4.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform UI Triaged CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-10 04:25 EDT by Martin Kalina CLA
Modified: 2019-09-06 15:37 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Kalina CLA 2010-05-10 04:25:11 EDT 
Build Identifier: M20080911-1700

Calling  ISaveablesLifecycleListener.handleLifecycleEvent() does not regsiter saveable in modelMap inside SaveablesList implementation, see first line of handleLifecycleEvent() method. When workbench.saveAll method is called then, method doSave() is not called on that saveable. This is in contradiction with IWorkbench.saveAll method comments ("Save all dirty saveables in the workbench...")

Reproducible: Always

Steps to Reproduce:
1. Implement Saveable and its ISaveablesSource, which does not implement also IWorkbenchPart 
2. call ISaveablesLifecycleListener.handleLifecycleEvent(ISaveableSource, POST_OPEN, ...)
3. call IWorkbench.saveAll()
4. No Saveable.doSave() method is invoked.
Comment 1 Remy Suen CLA 2010-05-10 06:13:48 EDT 
Please try with Eclipse 3.6M7.
http://download.eclipse.org/eclipse/downloads/
Comment 2 Eclipse Webmaster CLA 2019-09-06 15:37:24 EDT 
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.