Community
Participate
Working Groups
Build Identifier: 20100318-1801 In Expressions window the line "Add new expression" is very irritating when you are debugging some project with a number of expressions. Some checkbox/option should be added to switch off this line. Reproducible: Always Steps to Reproduce: 1. Open Expressions window.
Why is it annoying to have an extra entry at the end of the list? Having the entry makes it very easy to add a new expression. Unless having the entry is causing a well defined significant problem with the user workflow, we won't add a preference to tweak it. Closing as WONTFIX until a valid reason is suggested.
The Add new expression entry is only used when the expressions view is showing columns, which is also a new feature in 3.6. Would it help you to revert to the no columns layout (uncheck View Menu -> Layout -> Show Columns)?
Thanks, the view without columns is much better for me personally. I couldn't understand what was changed. Concerning a valid reason: 1) When you open a structure-tree for some object, this line ("Add new expression") may coalesce with data structure. And it is not convenient when you are distracted from the main task - debugging. 2) This is a duplication of context menu item in the same window. Also as additional tweaks - line colors/styles may be adjustable. In any case even if not doing line adjustable, why not to stretch it over all columns and center it or something like this. Currently this line is very non-intuitive. Btw, there are also some bugs with "Edit Expression" in column view (it sometimes becomes grayed out without a reason), I'll try to dig when this occurs and report another bug.
(In reply to comment #3) > Thanks, the view without columns is much better for me personally. I couldn't > understand what was changed. Hi Ivan, As a defect, would it satisfy your regression complaint if we changed the default layout to now show columns, then treat the rest of your suggestions as enhancements to this feature? > Concerning a valid reason: > 1) When you open a structure-tree for some object, this line ("Add new > expression") may coalesce with data structure. And it is not convenient when > you are distracted from the main task - debugging. By coalesce, do you mean that it visually blends with the debugger data? > 2) This is a duplication of context menu item in the same window. I don't quite understand this point, could you provide a screenshot explaining the context menu point? > Also as additional tweaks - line colors/styles may be adjustable. Do you mean that it would help if we changed the color of "Add new expression" to distinguish it more from user data? > In any case even if not doing line adjustable, why not to stretch it over all > columns and center it or something like this. Currently this line is very > non-intuitive. If you have the time to put together a screenshot mockup of the solution you're seeking that would be very helpful > Btw, there are also some bugs with "Edit Expression" in column view (it > sometimes becomes grayed out without a reason), I'll try to dig when this > occurs and report another bug. That would be helpful as well. Thank you.
Created attachment 168417 [details] Current look Image shows the duplication of functionality (red lines). Also "Add new expression" looks like a field of variable.
Hi Pawel, > As a defect, would it satisfy your regression complaint if we changed the > default layout to now show columns, then treat the rest of your suggestions as > enhancements to this feature? Maybe it is Ok, but I would like of course at least possibility to switch the line off. Because I personally cannot use column view now. > By coalesce, do you mean that it visually blends with the debugger data? Yes. Image shows this. > Do you mean that it would help if we changed the color of "Add new expression" to distinguish it more from user data? Yes. But what is comfortable for me can be irritating for others and vice versa, so configurable is better. > If you have the time to put together a screenshot mockup of the solution you're > seeking that would be very helpful I don't know yet what is better variant. As for me absence is the best now. Maybe I will get accustomed to it, but I don't rely on it to much :).
Created attachment 168477 [details] mocked up proposal (In reply to comment #6) > > By coalesce, do you mean that it visually blends with the debugger data? > Yes. Image shows this. I agree with this, perhaps a solution would be to add an icon to the "Add new Expression" to help make the vertical alignment more obvious. See attached mockup.
Created attachment 168548 [details] Screenshot mockup with the standard add icon. (In reply to comment #7) > I agree with this, perhaps a solution would be to add an icon to the "Add new > Expression" to help make the vertical alignment more obvious. See attached > mockup. Thank you for the constructive suggestion :-) Unfortunately, the "Add expression" icon is also used as the default expression icon so in some ways it blends in with the rest of the expressions even more. What if we switched the add icon to something more intuitive (see mockup).
+1 for the "+". I think we need the icon to be different than the rest and convey the message of "adding".
(In reply to comment #9) > +1 for the "+". I think we need the icon to be different than the rest and > convey the message of "adding". Cool! Ivan will it satisfy your concerns, (see also comments from the community: http://eclipse-debug.blogspot.com/2010/05/add-new-expression-inline-in.html)?
I guess I should make a patch before asking for a review :-) It'll have to wait till Monday though as I have some other priorities today.
As for "+", I think it should be better than current variant. However, why not to add checkbox into "Select Columns" window (possibly renaming the window and calling menu item to something like "Column View Options"). I personally also don't like to see a number of boxes and fields at a time in preferences, but adding a checkbox to this window should not make things worse. Especially taking into account this window is only available in columns view.
Created attachment 168841 [details] Patch adding the plus icon for the "Add new expression" element and actions.
This patch includes changes to plugin XML, content provider and JDT javadoc. Darin and Curtis please approve for RC2
(In reply to comment #12) > As for "+", I think it should be better than current variant. > However, why not to add checkbox into "Select Columns" window (possibly > renaming the window and calling menu item to something like "Column View > Options"). I personally also don't like to see a number of boxes and fields at > a time in preferences, but adding a checkbox to this window should not make > things worse. Especially taking into account this window is only available in > columns view. Thank you for your suggestion though I would rather avoid adding the new preference (in preferences dialog or otherwise). If you still feel that this solution is inadequate please open a new enhancement request and if it gets support from others in the community we'll certainly consider it again.
+1
+1 fixed in HEAD.
Verified by two committers.
