Community
Participate
Working Groups
Right now we have this test disabled in FullRegressionTestSuite since it needs third party dependency jars, now we need to let it run to catch feature bugs, the solution is we put the jars locally to our nightly machine to get it run. Also we need to seperated this test from FullRegressionTestSuite, create "run-bean-validation-tests" to run the test only if it finds the third party dependency jars.
Created attachment 167143 [details] changes to enable BeanValidationJUnitTest to run
Yiping, I'd be more comfortable with an additional path: bean.validation.run.classpath <path refid-run.path> <pathelement path="../../../extension.lib.external/${hibernate.jar}"/> <pathelement path="../../../extension.lib.external/${slf4j.jdk.jar}"/> <pathelement path="../../../extension.lib.external/${slf4j.api.jar}"/> <pathelement path="../../../extension.lib.external/${validation.api.jar}"/> and then have run-bean-validation-tests use: <param name="RUN_PATH" value="bean.validation.run.classpath"/> That way no additional jars are added to the classpath used by other tests either way. Otherwise looks good (though there are known sideeffects to using antcall to set paths). -Eric
Created attachment 167215 [details] updated patch
The changes are: - define properties of 4 validate jars needed for the testing in eclipselink.jpa.test/build.properties - add "run.bean.validation.classpath" to specify the classes needed to run bean validation tests, instead of adding the jars directly to "run.classpath" in eclipselink.jpa.test/build.xml - add "run-bean-validation-tests" target for bean validation tests only in eclipselink.jpa.test/build.xml and add comments before "run-bean-validation-tests" to say what kind of classes are needed to run the tests in eclipselink.jpa.test/build.xml - delete comments and "BeanValidationJunitTest" entry from FullRegressionTestSuite - small fix of testEmbeddedWithInvalidData() and testUpdateWithInvalidData() in BeanValidationJunitTest.java, the fix is provided by Mitesh code is reviewed by Edwin Tang, Eric Gwin, Mitesh Meswani
The Eclipselink project has moved to Github: https://github.com/eclipse-ee4j/eclipselink
