Bug 311340 - 'Guess' button in Apply Patch wizard not accurate enough
Summary: 'Guess' button in Apply Patch wizard not accurate enough
Status: ASSIGNED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Compare (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Platform-Compare-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-05-03 04:50 EDT by Dani Megert CLA
Modified: 2019-09-06 16:15 EDT (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2010-05-03 04:50:20 EDT
3.6 M6.

I often have the case where applying a patch results in conflicts because I already made some changes in my workspace. In this case I hope that pressing 'Guess' helps but it does not. Most of the time the guessed fuzz factor is much too low and when I then enter e.g. 100 manually, it just works fine.

We should improve the logic here.
Comment 1 Tomasz Zarna CLA 2010-05-17 08:52:39 EDT
A modified file and a patch for it that cannot be applied even when "Guess" is used, would be a good starter.
Comment 2 Dani Megert CLA 2010-05-17 09:08:51 EDT
It happens quite often to me, even without the file being modified at all.

Here's one example:1
1. check out 'org.eclipse.releng.tools' from HEAD as of today
2. paste the patch from attachment 89116 [details] into the Package Explorer
   ==> all files have conflicts
3. press 'Guess'
   ==> fuzz factor set to 1, only one file has no conflict
4. enter 100 as fuzz factor
   ==> now only 3 files remain with conflicts (much better)
Comment 3 Tomasz Zarna CLA 2010-05-17 10:23:49 EDT
Well, this is most probably because setting the factor to a value greater then number of context lines used in the patch results in completely ignoring the context. So in this case I assume setting the fuzz to 3 would give the same effect. Guessing does not allow to ignore all context line as described in bug 223317, comment 3. It doesn't mean we cannot change the way it works, but I'd rather inform the user about the fact.
Comment 4 Dani Megert CLA 2010-05-17 10:26:08 EDT
All I'm saying that normally when I enter a high number it just works i.e. I don't see/get any negative side effects and actually that's what I would expect out of the box.
Comment 5 Eclipse Webmaster CLA 2019-09-06 16:15:14 EDT
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.