Community
Participate
Working Groups
Build Identifier: 20090920-1017 Define an interface to connect SVN repositories with Mylyn Reviews (via the Subversive plug-in) Reproducible: Always
Created attachment 170326 [details] This archive contains the patch files with the implementation of the subversive svn connector for mylyn reviews - I have defined an extension point for the scm connectors in the core plugin. - SCM connector for svn (via subversive) implemented.
Created attachment 170814 [details] Extension point for scm connector and jaxb model
Created attachment 170815 [details] Changes in manifest file
Created attachment 170816 [details] Subversive connector plugin
Created attachment 170819 [details] Schema for extension point
There is a similar proposal in the Mylyn sandbox which is tracked on bug 326113: [scm] provide data model for change set retrieval. It would be great if we could merge these efforts so we don't end up duplicating implementation.
I was wondering what the status of this is. We are interested in being involved with the versions/reviews and wanted to merge our svn implementations.
That's great to hear. Vineet, can you give us a high-level sense of the scope of your SVN integration? Does it extend Subversive or Subclipse or is it something entirely different?
We have code review like back-end that we want to make available. Our engine works with CVS and Subclipse with prototypes for others. Instead of providing additional adapters we expect that we could build the capabilities as part of the Eclipse/Mylyn ecosystem.
I'm moving this to the Mylyn Versions project where we started implementing an abstraction over team connectors. Stefan, are you planning on working on this?
I am planning to start working on this, as it's needed in R4Eclipse, the goal is to support the interface with Subversive as well as with Subclipse, not sure if it will be feasible with the same connector The code in the attachments seem like a good start, any other references are welcome.
Great to hear! Please develop the connectors in two different bundles. The APIs are very different and we'll need to publish two different features. Before proceed with Subclipse we'll need to clarify the IP implications since Subclipse is not an Eclipse.org project and we may need to file a CQ etc.
Ok, I will experiment with subversive first.
A general question on IP. The code provided by Stefan Reiterer as a patch in this bug as well as the corresponding code for subclipse available in github i.e. git://github.com/sreiterer/mylyn-reviews-scm-integration.git are good bases to adapt the code to Mylyn versions. Considering that Stefan Reiterer is a committer and the code is posted as EPL, do we need to file CQs if we re-use some of the methods in them ?
The changes attached to this bug report were created prior to Stefan becoming a committer so we would have to treat them as contributions. The same applies to the code on github. Since Stefan is a committer on the project, I suggest that you work with him to adapt the changes to the new API and have Stefan commit them.
Good idea, see the follow up for the Subclipse connector under, Comment 18th in Bug 348899
Hello Alexander, do you know what is needed here? E.g. if I want to use R4E (Reviews for Eclipse) it just provides integration for Git and Subclipse. Thanks, Jörg
(In reply to comment #17) > Hello Alexander, > > do you know what is needed here? E.g. if I want to use R4E (Reviews for > Eclipse) it just provides integration > for Git and Subclipse. > > Thanks, Jörg Hi, As you said, currently R4E uses Mylyn Versions as SCM/Team API providers. Currently we have two connectors that implement Mylyn versions: One for Git and one for SVN via Subclipse. We haven't implemented any other connectors yet (although one for CVS also exists but was never tested with R4E). We do not plan other SCM connectors at this time but we invite the community to contribute should any other SCM connectors be necessary. Best Regards, Sebastien Dubois Mylyn Review committer and R4E project lead.
Hello Sebastien, we are using Mylyn and Subversive, but could not use R4E at the moment. Therefore, I put Alexander Gurov (Subversive project lead) on cc: and asked him directly whether he could contribute here. I was not sure whether he was already aware of this issue. Sadly, I lack Eclipse plugin competence and resources to contribute myself. Thanks, Jörg
(In reply to comment #19) > Hello Sebastien, > > we are using Mylyn and Subversive, but could not use R4E at the moment. > Therefore, I put Alexander Gurov (Subversive project lead) on cc: and > asked him directly whether he could contribute here. I was not sure whether > he was already aware of this issue. > > Sadly, I lack Eclipse plugin competence and resources to contribute myself. > > Thanks, Jörg Hi, Just a little note: Introducing a subversive plugin in Mylyn Versions should not be too big of a task, as a lot of code that is in the subclipse plugin could be adapted/reused. We did not do it ourselved because we had other priorities and nobody asked for such a plugin so far.
Thank you for perhaps the most level headed thing I have read today. I am sure there are many people who are faced with the same problems I recently had. I couldn't find an online service for merging PDF files, but eventually I found a simple one. I mostly use <a href="http://www.altomerge.com/" >http://www.altomerge.com/</a> to merge my PDFs. I think it also allows you to fill the merged documents.
