Bug 310798 - [framework] allow hiding "Attach context" button
Summary: [framework] allow hiding "Attach context" button
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: 3.3   Edit
Hardware: PC Linux
: P3 enhancement (vote)
Target Milestone: 3.4   Edit
Assignee: Benjamin Muskalla CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2010-04-28 07:41 EDT by Benjamin Muskalla CLA
Modified: 2010-04-29 20:20 EDT (History)
1 user (show)

See Also:

Attachments
patch (2.43 KB, patch)
2010-04-29 07:04 EDT, Benjamin Muskalla CLA 		no flags Details | Diff
mylyn/context/zip (60.79 KB, application/octet-stream)
2010-04-29 07:04 EDT, Benjamin Muskalla CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Muskalla CLA 2010-04-28 07:41:49 EDT 
It would be useful to hide the "Attach context" button the same way as with the submit button or private section (eg. AbstractTaskEditorPage#setNeedsAttachContext). There are connectors out there that do not support file attachements and the button in that case is pretty useless.
Comment 1 Steffen Pingel CLA 2010-04-28 12:46:37 EDT 
Makes sense to me. How about checking if the attachment handler provides an attachment handler that allows uploading for the current task? This would be equivalent to the action enablement for the context menu.

Are you interested in providing a patch :)?
Comment 2 Benjamin Muskalla CLA 2010-04-29 07:04:44 EDT 
Created attachment 166460 [details]
patch

Here we go ;-)
Comment 3 Benjamin Muskalla CLA 2010-04-29 07:04:49 EDT 
Created attachment 166461 [details]
mylyn/context/zip
Comment 4 Steffen Pingel CLA 2010-04-29 20:20:26 EDT 
Thanks! I have applied the patch.