Community
Participate
Working Groups
The icon for matching tags annotation is shown with a black background on OS X; using Eclipse Web Developer Tools 3.2.0.v201004210707. See attached screenshot.
Created attachment 166019 [details] matching_tags.png
Created attachment 194307 [details] sample icon
Created attachment 194308 [details] sample icon with black
This looks like it may be a problem with the AnnotationsConfigurationBlock#getImage when copying the data from the source images. I've attached two images. One is a red circle with a transparent background. The other is the same GIF but with a small, black dot in the red circle. If an annotation uses the red image, the transparency appears as normal. If the red image with the black dot is used, the background of the annotation icon becomes black. The transparency works correctly in Windows.
Markus can you check whether it's a bug in AnnotationsConfigurationBlock.getImage(AnnotationPreference) or SWT? Thanks.
The code in AnnotationsConfigurationBlock#getImage(..) should not do a pixel-wise copy in this case, since both images have the same size. If I add this, then the bug is gone: } else if (data.height == SIZE && data.width == SIZE) { copy= new Image(image.getDevice(), image, SWT.IMAGE_COPY); Nevertheless, there's a bug in SWT that need to be addressed: When I change the color in the "sample icon with black" to blue, then the bug is also gone. To reproduce, you can e.g. import o.e.jdt.ui and then add the icon to the "org.eclipse.jdt.ui.occurrences.write" annotation (in the plugin.xml, add line icon="$nl$/icons/full/test_after.gif" and put the icon there). Then open the Annotations preference page. To debug, set a breakpoint in ACB#getImage(..) with condition: "org.eclipse.jdt.ui.occurrences.write".equals(preference.getAnnotationType())
Created attachment 194407 [details] sample icon with blue
We've worked around the problem in case the icon is 16x16 pixels (bug 345180). To reproduce in HEAD, you have to revert attachment 195121 [details] or use an icon with smaller dimensions.
Created attachment 195741 [details] Testbed It turned out this area is shaky on all platforms, so I wrote a little test bed that shows all the problems we encountered.
Created attachment 195742 [details] Screenshots of testbed on Windows, Cooca, GTK On Cocoa, the problem with the black background only shows up if the Image(Device device, String filename) constructor is used and then the code in SnippetBug310387#createCenteredTableItem(String) is used to copy the image.
Still reproducible on GTK3.22, 4.8 M7, and Fedora 28.
(In reply to Markus Keller from comment #10) > Created attachment 195742 [details] > Screenshots of testbed on Windows, Cooca, GTK > > On Cocoa, the problem with the black background only shows up if the > Image(Device device, String filename) constructor is used and then the code > in SnippetBug310387#createCenteredTableItem(String) is used to copy the > image. The native ImageLoader implementation from bug 545032 fixes this issue on GTK.
New Gerrit change created: https://git.eclipse.org/r/146428
Created attachment 279651 [details] color problems with patch The patch fixes the black background in test_after.gif images. But it causes a few color issues as shown in the screenshot.
Gerrit change https://git.eclipse.org/r/146428 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=fde4082a50216a4b15c03a8f0f384b961bb953de
New Gerrit change created: https://git.eclipse.org/r/151142
Gerrit change https://git.eclipse.org/r/151142 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=d99c10172944ae97f07afc7bfdbeca6b3dfc1355
This seems to be again broken in the latest I-Build: https://download.eclipse.org/eclipse/downloads/drops4/I20191016-1800/gitLog.php https://git.eclipse.org/c/platform/eclipse.platform.swt.git/log/ So the problems with the colors are back. I also noticed issues with transparency.
New Gerrit change created: https://git.eclipse.org/r/151400
Gerrit change https://git.eclipse.org/r/151400 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=9756bf525499b6d339fdb17799a77299127a4023
@Sravan, Why are there multiple commits/reverts of the same change from https://git.eclipse.org/r/146428? As mentioned in comment#14 the gerrit patch causes color and transparent issues. They should be fixed before committing the change.
I am at loss on how to proceed on this problem. Any help from community os gratly appreciated.
Does the fact that when I run an older version of Eclipse 2019-03 - I don't get the problem help ?
*** Bug 549210 has been marked as a duplicate of this bug. ***
*** Bug 551605 has been marked as a duplicate of this bug. ***
Created attachment 280588 [details] As requested screen dump - this time with WB 1.92 and Eclipse 2019 12 As requested screen dump - this time with WB 1.92 and Eclipse 2019 12
Just wondered if there has been any progress on this issue ?
Any news on this. I'm unable to move beyond 2019-03 on MacOS with this issue.
When an image is created with ImageData the transparency is not handled properly on Mac. the problem is there in this method https://git.eclipse.org/c/platform/eclipse.platform.swt.git/tree/bundles/org.eclipse.swt/Eclipse%20SWT/cocoa/org/eclipse/swt/graphics/Image.java#n682 At this particular line a new image data is created which included alpha data. but the alpha data is completely ignored in the subsequent execution. This is resulting in black background Need help in separating alpha data into a mask. Any help is appreciated
New Gerrit change created: https://git.eclipse.org/r/156180
Gerrit change https://git.eclipse.org/r/156180 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=e99324ff81e11fa8d973b8fcbb10ee69da8a5188
Merged to master
The change seems to cause problems in breadcrumb view - Bug 559705.
Created attachment 281658 [details] Comparison 1.9.2 v 1.9.3 screen dumps MacOS I have updated Eclipse 2019-12 to version 1.9.3 and attached screen dumps comparing the same windowbuilder toolbars before and after.
(In reply to Dave Garratt from comment #34) > Created attachment 281658 [details] > Comparison 1.9.2 v 1.9.3 screen dumps MacOS > > I have updated Eclipse 2019-12 to version 1.9.3 and attached screen dumps > comparing the same windowbuilder toolbars before and after. Dave, we know 2019-12 has the issue. It would be nice if you could compare to the latest build from here: https://download.eclipse.org/eclipse/downloads/ e.g. https://download.eclipse.org/eclipse/downloads/drops4/I20200129-1800/
WindowBuilder 1.9.2 seems to display ok with the version of Eclipse you suggest although I have other non related problems which I can elaborate on if your interested,
(In reply to Dave Garratt from comment #36) > WindowBuilder 1.9.2 seems to display ok with the version of Eclipse you > suggest although I have other non related problems which I can elaborate on > if your interested, What about WB 1.9.3 on that version? Please file issues for the other non-related problems.
Just tried 1.9.3 with Version: 2020-03 (4.15) Build id: I20200131-1800 and it looks ok (from the perspective of WindowBuilder) but I'm not sure what to expect from Eclipse itself which seems to be missing lots of screens/properties. For example there are no views for "Servers" which can be opened or added so my servlet won't work. The Java Swing app complained about the Java JRE which had previously been defined in a facet but the properties of the project seemed to only contain about 50% of the options I would normally see and facet was not present. Anyway = I have attached a screen dump of WindowBuilder. Let me know what I should expect from this build of eclipse. I don't want to report things if it's not expected to work fully as yet. Normally I would use the Java EE version of Eclipse
Created attachment 281673 [details] 1.9.3 with Eclipse 4.1.5
(In reply to Dave Garratt from comment #38) > > Let me know what I should expect from this build of eclipse. I don't want to > report things if it's not expected to work fully as yet. Normally I would > use the Java EE version of Eclipse Hey Dave. This version of Eclipse is just the SDK. It does not have all the bells and whistles of the various packages. The various packages you can download, all take the SDK and put their specific projects on top of that. I can't find a nightly download for the packages [1] so I filed [2]. The earliest developer package available is M3 (Feb 28) [3] [1] https://www.eclipse.org/epp/ [2] https://bugs.eclipse.org/bugs/show_bug.cgi?id=559766 [3] https://wiki.eclipse.org/Category:SimRel-2020-03
(In reply to Sravan Kumar Lakkimsetti from comment #32) > Merged to master Thanks, Sravan!
SO - ignore my comments about eclipse options looking different - that was because I am used to using the EE edition. The graphics problem appears to be fixed. Dave
Marking it verified based on comment 42
Well done Sravan, this was not an easy thing to fix.
We're experiencing this issue with JFace's CompositeImageDescriptor in our RCP application based on 2019-06. Is there any alternative to updating the target platform?
(In reply to Jochen Kemnade from comment #45) > We're experiencing this issue with JFace's CompositeImageDescriptor in our > RCP application based on 2019-06. Is there any alternative to updating the > target platform? Yes, you can make a "feature patch".
Thanks for the hint. Just to be sure that I'm trying to do the right thing: I would try to create a feature patch for the org.eclipse.swt.cocoa.macosx.x86_64 bundle and add a patched Image.class file?
(In reply to Jochen Kemnade from comment #47) > Thanks for the hint. Just to be sure that I'm trying to do the right thing: > I would try to create a feature patch for the > org.eclipse.swt.cocoa.macosx.x86_64 bundle and add a patched Image.class > file? Yes.
(In reply to Wim Jongman from comment #48) I'm having trouble getting this to work, maybe because org.eclipse.swt.cocoa.macosx.x86_64 is a fragment. It doesn't seem possible to reference it in the feature patch's feature.xml ... <requires> <import feature="org.eclipse.swt.cocoa.macosx.x86_64" version="3.111.0.v20190605-1801" patch="true"/> </requires> ...
This bug has re-appeared now that I have installed Eclipse 2020 09 on Mac with WindowBuilder 1.9.4.202009181620
Created attachment 284229 [details] Palette Display Example WIndowBuilder 1.9.4 Eclipse 2020 09 Note this time the issue seems limited to the palette and does not affect the toolbar.
I have created a new ticket Bug 567266
