Bug 310084 - DBCS3.6: Duplicate "OverrideIndicator" annotation
Summary: DBCS3.6: Duplicate "OverrideIndicator" annotation
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: PDT (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: PHP UI CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-04-22 06:24 EDT by Missing name CLA
Modified: 2020-05-14 11:33 EDT (History)
7 users (show)

See Also:


Attachments
screen capture (121.59 KB, image/jpeg)
2010-04-22 06:25 EDT, Missing name CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Missing name CLA 2010-04-22 06:24:57 EDT
Build Identifier: I20100419-1343

"OverrrideIndicator" annotation is duplicated at the preference page. "Override Indicators" already exists as the annotation types. It could be confusing for users.



Reproducible: Always

Steps to Reproduce:
1. Launch the Preference ("Window" -> "Preference...")
2. Go to "General" -> "Editors" -> "Text Editors" -> "Annotation"
You can find that the "OverrideIndicator" annotation is duplicated.
Comment 1 Missing name CLA 2010-04-22 06:25:23 EDT
Created attachment 165726 [details]
screen capture
Comment 2 Missing name CLA 2010-04-22 06:36:33 EDT
This is a common problem, not a globalization unique. 

Expected result: These annotations must be clearly distinguished.
Comment 3 Ed Willink CLA 2010-04-22 11:49:28 EDT
OCL does not currently ship any editors (hoping to add an Editor example for M7).

The string OverrideIndicator appears nowhere in OCL source.

When I start an Eclipse with OCL plugins I do not see the duplicate.
Comment 4 Missing name CLA 2010-04-22 23:06:56 EDT
Change the product to IMP.
Comment 5 Robert M. Fuhrer CLA 2010-06-04 11:53:56 EDT
I can't see how IMP could be causing this problem either - we only define two annotation types (parserAnnotation and occurrenceAnnotation), neither of which have anything to do with the override indicator.

A case-insensitive search for the string "OverrideIndicator" in all of the IMP source turned up one commented-out instance in a line in OutlineInformationControl, as part of the JDT class name OverrideIndicatorLabelDecorator. That line has been commented out since at least Feb 2008.

In an Eclipse w/ several IMP-based IDEs installed, in "Editors" -> "Text Editors" -> "Annotations", I see 3 annotation types whose labels mention "Override":
 - Override
 - Override indicators (org.eclipse.jdt.ui.overrideIndicator)
 - Override indicators (org.eclipse.php.ui.overrideIndicator)
 
As you can see, the second of these is from the JDT, the third is from the PHP IDE (which I also have installed). I don't know where the "Override" annotation type is coming from, but again, IMP doesn't define any such annotation type.

If I run a runtime workbench with all of IMP, but most of the additional extraneous plugins (like the PHP-related ones) that are not necessary for or related to IMP, I see only one instance of "Override indicators" in the Annotations prefs page, and I also don't see the "Override" annotation type.

So, I conclude this isn't an IMP problem; I suggest you look elsewhere for the resolution.
 
Changing product back to MDT.
Comment 6 Ed Willink CLA 2010-06-04 12:32:37 EDT
This is clearly not OCL.

This is clearly not IMP.

Robert's analysis shows that it is JDT or PHP.
Comment 7 Markus Keller CLA 2010-06-04 13:11:04 EDT
This preference page is from the Platform/Text component.

Moving to PDT to fix the name of the annotation. If it's exactly
"Override Indicators", the page should resolve the conflict and show the contributor of each annotation. Filed bug 315802 to improve the rendering of collisions.
Comment 8 Zhongwei Zhao CLA 2010-07-26 20:35:43 EDT
fixed already
Comment 9 Sylvia Tancheva CLA 2010-09-01 10:07:04 EDT
Looks OK to me (Pdt-2.2.0.v20100605)
I also see only:
- Override
- Override indicators (org.eclipse.jdt.ui.overrideIndicator)
- Override indicators (org.eclipse.php.ui.overrideIndicator)
Closing