Community
Participate
Working Groups
Build Identifier: It would be great to have generic solution to add the button to the bottom of the page where 'Finish' and 'Cancel' buttons are placed (but on the left). Reproducible: Always
That sounds like a good idea but how would that work when the page is displayed in the Eclipse search dialog (Ctrl+H)? Also note this related task: bug 229817: add clear button to search pages .
(In reply to comment #1) > That sounds like a good idea but how would that work when the page is displayed > in the Eclipse search dialog (Ctrl+H)? Also note this related task: bug 229817: > add clear button to search pages . Steffen, should we support this for 'new Query' and 'Query Property' and support the search dialog when we have an way to change the OpenSearchDialogAction to open an other Dialog where we can support the needed functions. Thoughts?
Yes, that makes sense to me. The ValidatableWizardDialog is an example how to make that work. Maybe there is some potential for generalization to apply the same principle to the query dialogs. For the cases where we can't contribute to the dialog button bar the buttons should be displayed on the bottom of the page. It would be nice to make that part of AbstractRepositoryQueryPage2 and also add API for the collapsable sections that you implemented for Bugzilla (and then make Bugzilla extend AbstractRepositoryQueryPage2).
Created attachment 191967 [details] patch V1 Steffen, Rob, please verify!
Created attachment 191968 [details] mylyn/context/zip
Sorry, I didn't get around to looking at this. Let's apply it early in 3.7.
Steffen, should I recreate the patch now?
Yes, this would be a good time to implement this abstraction. Note that we should consider putting this support into AbstractRepositoryQueryPage2 and also consider generalizing the "Clear Fields" button.
I have the patch in the following git branches http://git.eclipse.org/c/mylyn/org.eclipse.mylyn.tasks.git/log/?h=bug%23310059 (sorry wrong commit message) http://git.eclipse.org/c/mylyn/org.eclipse.mylyn.commons.git/log/?h=bug%23310059 Please review!
Created attachment 200622 [details] mylyn/context/zip
Frank, I revied the Mylyn Commons portion of the change. Can we rename the class to EnhancedWizardDialog following the pattern we have used in other places? Please feel free to rebase on master and commit that. I hope I'll get around to reviewing the remainder of the changes soon.
For the tasks.ui part I would prefer if the new API was added to AbstractRepositoryQueryPage instead of introducing a new interface IQueryButtomButtons. We can ensure backwards compatibility through the boolean capabilities that you added, i.e. needsClearFields() and needsUpdateConfiguration(). Some of this code is already implemented in AbstractRepositoryQueryPage2. I think we should merge AbstractRepositoryQueryPage2 into AbstractRepositoryQueryPage and deprecate the former. We will also need to handle the case when the query page is embedded in the search dialog. In that case the buttons should be displayed on a composite on the bottom of the page. We may also want to add a progress area since the search dialog does not have built-in support for monitoring progress (bug 245152). Does that make sense?
The Mylyn Commons portion is now in GIT master!
(In reply to comment #12) > For the tasks.ui part I would prefer if the new API was added to > AbstractRepositoryQueryPage instead of introducing a new interface > IQueryButtomButtons. We can ensure backwards compatibility through the boolean > capabilities that you added, i.e. needsClearFields() and > needsUpdateConfiguration(). > > Some of this code is already implemented in AbstractRepositoryQueryPage2. I > think we should merge AbstractRepositoryQueryPage2 into > AbstractRepositoryQueryPage and deprecate the former. We will also need to > handle the case when the query page is embedded in the search dialog. In that > case the buttons should be displayed on a composite on the bottom of the page. > We may also want to add a progress area since the search dialog does not have > built-in support for monitoring progress (bug 245152). > > Does that make sense? OK, I start with this now!
(In reply to comment #12) > Some of this code is already implemented in AbstractRepositoryQueryPage2. I > think we should merge AbstractRepositoryQueryPage2 into > AbstractRepositoryQueryPage and deprecate the former. We will also need to > handle the case when the query page is embedded in the search dialog. In that > case the buttons should be displayed on a composite on the bottom of the page. > We may also want to add a progress area since the search dialog does not have > built-in support for monitoring progress (bug 245152). > > Does that make sense? We need to make sure that the other usage of AbstractRepositoryQueryPage did not brake (6 other classes).
For now I keep AbstractRepositoryQueryPage2 see http://git.eclipse.org/c/mylyn/org.eclipse.mylyn.tasks.git/log/?h=bug%23310059_patch2 Steffen, after the review I change the other 5 classes.
This looks like a good start! I would suggest that we move the API for the Clear button up to AbstractRepositoryQueryPage2 so we have a common implementation. Some minor problems I noticed in a quick UI review: * The button panel has padding that should be removed * The attribute composite has a border in the query dialog * The clear and update buttons should be left aligned on the search page * The button labels should be changed to "Clear Fields" and "Refresh Configuration".
Steffen, I did the changes from comment#17.
Created attachment 202105 [details] mylyn/context/zip
I have created a code review here: http://review.mylyn.org/#change,2
The changes are now in master. Thanks for driving this Frank. I'll look into merging AbstractRepoisitoryQueryPage2 into AbstractRepoisitoryQueryPage and adding the progress bar.
Can you attach a screenshot of the new query dialog on Mac? I would like to put this up for UI review on the Mylyn call.
Created attachment 202351 [details] screenshot Edit Query
Created attachment 202352 [details] screenshot Search Window
Thank for the screenshots. The feedback on the call was very good. We had two suggestions: * Consider renaming "Refresh Configuration" to "Refresh" * The icon causes the Refresh button to be larger than the other buttons. Is there a way to reduce padding on the button? Otherwise we should consider removing the icon or using a 12x12 icon.
(In reply to comment #25) > Thank for the screenshots. The feedback on the call was very good. We had two > suggestions: > > * Consider renaming "Refresh Configuration" to "Refresh" Done! > * The icon causes the Refresh button to be larger than the other buttons. Is > there a way to reduce padding on the button? Otherwise we should consider > removing the icon or using a 12x12 icon. I remove the icon because i did not find a way to reduce the size even with the 12X12 icon I get an height of 32! ID=46912ef6facbb5b2e94fad430d0e7cf324bfa3f8
I have moved AbstractRepositoryQueryPage2 to org.eclipse.mylyn.tasks.ui.wizards (the provisional implementation is still around but deprecated and likely to be removed for 3.7). The following API enhancements are now available: * A title field is provided by the framework if the search page is used in the query dialog. * Refresh and Clear buttons are provided by the framework: Refresh updates the repository configuration and clear resets all entry fields in the dialog. * The Refresh and Clear buttons are displayed on the lower left on the button bar of the query dialog when editing existing queries. * The search page refreshes the repository configuration on repository selection if it is not available. * The progress bar is now embedded in the search page to avoid blocking navigation in the search dialog. Clients are encouraged to extend AbstractRepositoryQueryPage2 instead of AbstractRepositoryQueryPage when building on Mylyn 3.7 or later.
Created attachment 203753 [details] screenshot on win7
Created attachment 203871 [details] trac query dialog
Created attachment 203872 [details] Bugzilla Query Dialog
Created attachment 203873 [details] Bugzilla Search Page
