Community
Participate
Working Groups
I20100414-1200. 1. start new workspace 2. open Project Explorer 3. drag a file from the OS file explore to the Project Explorer ==> a [+] feedback appears giving the impression that copy is possible [BUG] 4. drop it ==> a dialog appears [BUG]
Serge, do you think this is yours or do you want me to have a look?
This is basically the same bug as bug 302441
From looking at the code, I think there's some limitations that prevent the DROP_MOVE operation to be set. Anyhow, fundamentally, this is a limitation of SWT that it doesn't have a DROP_PROMPT operation. Otherwise, in Windows Explorer for example, the 'prompt' drag and drop cursor is the same as the 'copy' one (when drag and drop with the right click).
(In reply to comment #3) > From looking at the code, I think there's some limitations that prevent the > DROP_MOVE operation to be set. Can you elaborate on this? By default it should be a move right, unless control is pressed then it's a copy? (on Windows).
Created attachment 165620 [details] Patch that makes the operation change appropriately given the target. For this to work, it requires a API addition in CommonDropAdapterAssistant.java. The getDragOperation() method should be integrated into ImportTypeDialog in 3.7 and made API.
(In reply to comment #5) > Created an attachment (id=165620) [details] > For this to work, it requires a API addition in > CommonDropAdapterAssistant.java. We don't need to make this API, just mark it @noreference (I think), and then you will need to add an API filter to the o.e.ui.navigator.resources for the exception.
IMPORTANT NOTE (not sure whether this was understood): This bug is only about moving over the EMPTY Project Explorer (or if there are elements, when not moving over one of them). In that scenario we must show the DROP_NONE feedback and not show [+] and then a dialog.
This used to work just fine before, so I don't see why we would need new API for this.
(In reply to comment #7) > IMPORTANT NOTE (not sure whether this was understood): This bug is only about > moving over the EMPTY Project Explorer (or if there are elements, when not > moving over one of them). In that scenario we must show the DROP_NONE feedback > and not show [+] and then a dialog. Ah, sorry, I didn't get that, I though it was about the drop operation over a given container
And while looking at your patch for bug 301187 I think we should not touch the DND feedback i.e. not show LINK feedback when link is set. If we'd do so, it has many consequences and also results in different code paths which aren't covered yet. We should probably wait with that for 3.7.
This is a regression which must be fixed for 3.6.
(In reply to comment #11) > This is a regression which must be fixed for 3.6. Ok, I don't really understand what's going on here, who is going to fix this today?
Too late for M7. Moving to RC1. +1 to fix this during RC1 since this is an ugly regression introduced during M6. Serge, I guess you know best which changes you made to DnD for the link/group support.
>Too late for M7. Moving to RC1. +1 to fix this during RC1 since this is an ugly >regression introduced during M6. Oops, sorry guys: t looks like that bug (giving copy feedback is in since the beginning and since 3.5 we show the dialog on drop (before nothing happened).
(In reply to comment #14) > >Too late for M7. Moving to RC1. +1 to fix this during RC1 since this is an ugly > >regression introduced during M6. > Oops, sorry guys: t looks like that bug (giving copy feedback is in since the > beginning and since 3.5 we show the dialog on drop (before nothing happened). Guess it's my problem now. :)
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.
