Bug 309978 - [Webapp] Accessibility issue--all jsp files miss lang attribute in html tag
Summary: [Webapp] Accessibility issue--all jsp files miss lang attribute in html tag
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: User Assistance (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.6 M7   Edit
Assignee: Chris Goldthorpe CLA
QA Contact:
URL:
Whiteboard:
Keywords: accessibility
Depends on:
Blocks:
 
Reported: 2010-04-21 11:04 EDT by Hao Zhang CLA
Modified: 2010-04-23 03:52 EDT (History)
3 users (show)

See Also:

Attachments
Patch (29.21 KB, patch)
2010-04-21 13:43 EDT, Chris Goldthorpe CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hao Zhang CLA 2010-04-21 11:04:21 EDT 
All jsp files in webapp miss the 'lang' attribute to html tag, which may be a violation in accessibility check.
Comment 1 Chris Goldthorpe CLA 2010-04-21 13:21:31 EDT 
I think that the way to fix this would be to add a resource in WebappResources.properties to represent the locale of the translation being used and use that for the value of the lang attribute. That way the lang attribute will be consistent with the localized strings used in the page.

It will require changing every jsp file that contains a <html> tag, 38 files in all. I think that this should be fixed as screen readers use the "lang" attribute. I will create a patch and have Vivian test it.
Comment 2 Chris Goldthorpe CLA 2010-04-21 13:43:46 EDT 
Created attachment 165608 [details]
Patch
Comment 3 Kit Lo CLA 2010-04-21 13:53:35 EDT 
Chris, the comment in the WebappResources.properties file is useful:

# The locale of this translation of the resource file, will be used as follows: <html lang = "en">

But, could you add another line to tell the translators to change that to the locale for their language?
Comment 4 Chris Goldthorpe CLA 2010-04-21 14:32:14 EDT 
I have added some extra lines of comment and committed the patch, Vivian, can you verify that this fixes the problem?
Comment 5 Hao Zhang CLA 2010-04-22 10:42:40 EDT 
Patch looks good. 

I'll also let tester to verify it through screen reader tool(JAWS).
Comment 6 Hao Zhang CLA 2010-04-23 03:52:00 EDT 
It is verified through JAWS.