Community
Participate
Working Groups
build I20030129 While cleaning up WorkbenchActionBuilder, I noticed that the following actions are missing their action definition ids: import, export, saveAsAction, pinEditorAction, aboutAction, openPreferencesAction, quickStartAction, hideShowEditorAction, savePerspectiveAction, editActionSetAction, lockToolBarAction, resetPerspectiveAction, closePerspAction, closeAllPerspsAction
can you take a look through this doug? i'm not sure how many of these have been updated to have command ids since this report was filed. i think all of these action should have command ids ('action definition ids') to allow key bindings.
Here is the up-to-date list of actions that appear to be undefined. Not only can I not find mention of them in "plugin.xml", but there is no visible setting of their definition IDs. closeAllPersps closePersp editActionSet hideShowEditor lockToolBar newWizardDropDown newWizardMenu openPreferences resetPerspective savePerspective exportResources (setId in constructor) importResources (setId in constructor) pinEditor (setId in constructor) saveAs (setId in constructor) The following appear, at first glance, to be undefined, but they exist in the plugin.xml and they programmatically set their actionDefinitionIds in their constructors. They are also available in the KeysPreferencePage. about (setId and setActionDefinitionId in constructor) newWizard (setActionDefinitionId in constructor) quickStart (setActionDefinitionId in constructor) tipsAndTricks (setActionDefinitionId in constructor)
Created attachment 6053 [details] Patch to plugin.xml and plugin.properties Added command definitions and internationalized text for the missing commands.
Created attachment 6054 [details] Patch to WorkbenchActionBuilder and ActionHandler WorkbenchActionBuilder has gained several constants defining the new command IDs. The action which were missing command IDs now get them defined, and are all added as global actions. ActionHandler has been modified so that it updates the "checked" property of the jface IAction that it holds. Without this, commands represented by checkable widgets don't tend to generate the desired effects when triggered through the key binding architecture. For example, "Lock the Toolbars" and "Pin Editor".
Tested under UiTestSuite and AllTests (org.eclipse.ui.tests), and everything passed ( ... except for StructureViewerTest.testClearSelection, which is failing even without the patch right now). chris: I'm sending this patch to you as it involves ActionHandler. Side note: the patch include the removal of two unnecessary casts from WorkbenchActionBuilder.
fixed.
