Bug 307729 - [upstream] support reading and updating the See Also field
Summary: [upstream] support reading and updating the See Also field
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 3.15   Edit
Assignee: Frank Becker CLA
QA Contact:
URL: https://bugzilla.mozilla.org/show_bug...
Whiteboard:
Keywords: noteworthy
Depends on: 320202
Blocks:
  Show dependency tree
 
Reported: 2010-03-31 09:13 EDT by Attila Szökrönyös CLA
Modified: 2015-02-25 15:17 EST (History)
3 users (show)

See Also:


Attachments
Support for adding, reading and deleting See Also entries (6.31 KB, patch)
2010-03-31 09:44 EDT, Attila Szökrönyös CLA
no flags Details | Diff
mylyn/context/zip (10.21 KB, application/octet-stream)
2010-03-31 09:44 EDT, Attila Szökrönyös CLA
no flags Details
mylyn/context/zip (339.13 KB, application/octet-stream)
2015-02-02 08:33 EST, Frank Becker CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Attila Szökrönyös CLA 2010-03-31 09:13:45 EDT
Support for read/update/delete of the See Also field is missing from the Bugzilla connector. Adding new entries to the See Also field is working atm, although the necessary enums and constants are missing from BugzillaAttribute.java and Messages.java. Reading the contents of a bug's see also field is not possible, BugzillaClient.getTaskData() does not return such an attribute. Removing separate See Also entries is also not possible.

For adding read support the SaxMultiBugReportContentHandler.endElement() method can be extended with a new case block, similar to eg.: DEPENDSON
Support for adding new entries only needs new constant and enum definitions in BugzilllaAttribute.java and Messages.java/messages.properties
Support for deleting See Also entries needs also new constant and enum defs and some modification in BugzillaClient.getPairsForExisting(). The handling of See Also deletion is done through a new attribute called remove_see_also. In one operation several see also entries can be removed.
Comment 1 Attila Szökrönyös CLA 2010-03-31 09:44:21 EDT
Created attachment 163529 [details]
Support for adding, reading and deleting See Also entries

Manul tests have been performed.
Comment 2 Attila Szökrönyös CLA 2010-03-31 09:44:24 EDT
Created attachment 163530 [details]
mylyn/context/zip
Comment 3 Frank Becker CLA 2010-04-02 16:51:28 EDT
Attila,

I did a review and found the following

* UI only works when you have one value in see_also. More then one is not correctly supported.
* there is no way to add a value if you not already have one.
* Better UI like Add CC: and CC:

Can you create a new patch or should I resolve this?
Comment 4 Attila Szökrönyös CLA 2010-04-06 06:02:54 EDT
Frank, I will take a look at it. I must admit I haven't checked how the UI behaves with this patch, only tested if the direct API calls are working.
Comment 5 Frank Becker CLA 2010-07-18 05:21:55 EDT
For a full support we need  a fix for https://bugzilla.mozilla.org/show_bug.cgi?id=557183 because the usage of this field can be off in the administation of bugzilla.
Comment 6 Steffen Pingel CLA 2011-09-28 06:14:44 EDT
Is there any concern with applying the patch meanwhile?
Comment 7 Frank Becker CLA 2011-09-30 14:14:56 EDT
(In reply to comment #6)
> Is there any concern with applying the patch meanwhile?

I think we need the fix for https://bugzilla.mozilla.org/show_bug.cgi?id=557183
Comment 8 Sam Davis CLA 2015-01-30 13:37:01 EST
Frank, it would be useful to support the See Also field now that eclipse.org is going to use it to link to Gerrit reviews and commits (see bug 434841). Would you be interested in working on this?
Comment 9 Frank Becker CLA 2015-02-02 08:33:52 EST
create review https://git.eclipse.org/r/40894
Comment 10 Frank Becker CLA 2015-02-02 08:33:59 EST
Created attachment 250437 [details]
mylyn/context/zip
Comment 11 Frank Becker CLA 2015-02-04 02:19:22 EST
If you do not see the "See Also" Editor please check if in the Task Repository Properties under "Additional Setting" the "See Also" is not checked (group "Task Editor Attributes to Suppress").
Comment 12 Frank Becker CLA 2015-02-25 15:17:53 EST
Nothing left to do!