Bug 306852 - Help tray in dialogs not wide enough to show all toolbar buttons
Summary: Help tray in dialogs not wide enough to show all toolbar buttons
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: User Assistance (show other bugs)
Version: 3.6   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.6 M7   Edit
Assignee: Chris Goldthorpe CLA
QA Contact:
URL:
Whiteboard:
Keywords: polish
Depends on:
Blocks:
 
Reported: 2010-03-23 13:52 EDT by Markus Keller CLA
Modified: 2010-03-30 16:21 EDT (History)
3 users (show)

See Also:

Attachments
Patch (12.33 KB, patch)
2010-03-30 16:17 EDT, Chris Goldthorpe CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2010-03-23 13:52:32 EDT 
N20100322-2000

The help tray in dialogs is not wide enough to show all toolbar buttons.

Steps:
- File > New > Other...
- click the help button
- in the tray, click Resources
=> the close button in the tray toolbar is not visible. Since the help button is not a toggle (bug 127852), I have to enlarge the tray to make the close box visible.

In my main install, I also have a button 'Show All Topics' and a separator at the beginning of the toolbar, so it's even wider. I don't know what makes that button appear.
Comment 1 Chris Goldthorpe CLA 2010-03-23 14:22:48 EDT 
Two new buttons were added in Eclipse 3.6 to increase/decrease the font size. If these were moved to the drop down menu we would have less buttons on the toolbar.
Comment 2 Eric Moffatt CLA 2010-03-23 14:52:29 EDT 
Chris, +1 for moving them to the menu, they will only ever be used occasionally...
Comment 3 Chris Goldthorpe CLA 2010-03-30 16:17:32 EDT 
Created attachment 163452 [details]
Patch

This patch moves the actions to change the font size from the toolbar to the drop down menu in the help view. In the help tray which does not have a drop down menu these buttons will not show.

The buttons to change the font size were added to address the concerns of users who find the text in the help view too small to read, and the typical usage is to click the button once or twice to make the text larger, and once the text size is acceptable leave the font size unchanged. It makes sense to move the buttons to a drop down because they will not be used frequently.

The help tray currently does not have a drop down menu and I'm not sure whether it should have one or not. If we were in an earlier milestone I would probably be adding a drop down menu to the help tray but since it is M7 I am going to leave the drop down as well as the actions to magnify and reduce the font size out of the help tray. Any font size changes made in the help view will be reflected in the help tray.
Comment 4 Chris Goldthorpe CLA 2010-03-30 16:21:04 EDT 
Patch committed, Fixed