Community
Participate
Working Groups
Created attachment 162621 [details] Package Constructor, Wizard and Tests As was discussed in Bug 299342 ("New Java Package" option should automatically create a Java Project) and Bug 303427 (Can't specify a source folder in the Package Wizard), we should have a constructor for packages, similar to those for Java projects and Java classes. This patch includes the package constructor and some basic tests for it; as well, it has the reworked package wizard. There are still things to be improved (as with the project and class constructors), but it's a start.
I like it. There is a user interface guideline that states that wizards should not open in an error state. I see an opportunity to do something cool here... We can open the wizard with "mypackage" as the default package if no other packages exist. But if other packages do exist, we can assume that the new one will be some variation of what's there. For example, if there are two packages "org.eclipse.stuff" and "org.eclipse.junk", then we can probably assume that the next package will be named something that starts with "org.eclipse.". Perhaps we could suggest something like "org.eclipse.newpackage". We could even highlight the "newpackage" part by default... Just some thoughts. After we apply this patch, perhaps we can open a new bug to address this opportunity. Since the patch is >250LOC, I have to open a CQ to allow the IP team to have a look at it before we can apply it. I will open the CQ presently.
Created attachment 163350 [details] mylyn/context/zip
Brenda, can you make a statement on this bug to indicate that you wrote 100% of the code contained in the patch? The IP Team is going to ask...
I wrote 100% of the code in this patch.
Created attachment 197471 [details] Brenda's patch with license headers added I've added license headers in anticipation of providing these files to the IP team for their review.
Are you still around Brenda? Sorry for the delay in getting to this patch, but I would like to accept it. Can you please explicitly assert the following? 1. He/She confirms they authored 100% of the content they are submitting 2. He/She confirms they have the rights to contribute the content to Eclipse 3. He/She confirms the content is being submitted under the project license in this case EPL You've already done #1, I just need a word from you indicating that #2 and #3 are also true.
*** Bug 299342 has been marked as a duplicate of this bug. ***
Note that when we apply this patch, we can (and should) remove NewLitePackageWizardPage.
(In reply to comment #6) > Are you still around Brenda? Sorry for the delay in getting to this patch, but > I would like to accept it. > > Can you please explicitly assert the following? > > 1. He/She confirms they authored 100% of the content they are submitting > 2. He/She confirms they have the rights to contribute the content to Eclipse > 3. He/She confirms the content is being submitted under the project license in > this case EPL > > You've already done #1, I just need a word from you indicating that #2 and #3 > are also true. No problem. 2. I confirm that I have the rights to contribute the content to Eclipse. 3. I confirm that the content is being submitted under the project license. -Brenda
Thanks Brenda. I have created CQ 5269 to request IP review (sorry, only accessible by committers). https://dev.eclipse.org/ipzilla/show_bug.cgi?id=5269
