Bug 306264 - [NLS] Some of the syntax elements for CSS are not themed for high contrast
Summary: [NLS] Some of the syntax elements for CSS are not themed for high contrast
Status: RESOLVED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: wst.css (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2 M7   Edit
Assignee: Nick Sandonato CLA
QA Contact: Nick Sandonato CLA
URL:
Whiteboard: PMC_approved
Keywords: accessibility
Depends on:
Blocks:
 
Reported: 2010-03-17 15:32 EDT by Nick Sandonato CLA
Modified: 2010-04-22 12:25 EDT (History)
2 users (show)

See Also:
david_williams: pmc_approved+
nsand.dev: pmc_approved? (raghunathan.srinivasan)
nsand.dev: pmc_approved? (naci.dai)
nsand.dev: pmc_approved? (deboer)
nsand.dev: pmc_approved? (neil.hauge)
nsand.dev: pmc_approved? (kaloyan)
thatnitind: review+

Attachments
patch (3.53 KB, patch)
2010-04-15 17:30 EDT, Nick Sandonato CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Sandonato CLA 2010-03-17 15:32:19 EDT 
In 3.2, some new syntax elements were added for CSS. These currently aren't themed for high contrast.

So, while in high contrast, most syntax elements are white, ID, classes, the universal selector, attribute selectors, and pseudo-classes will remain their normal color.
Comment 1 Nick Sandonato CLA 2010-04-15 17:30:11 EDT 
Created attachment 165022 [details]
patch

Submitting a patch to add the correct elements to the theme for accessibility. The extension point requires the color definitions to have a label, and thus would require some translation.
Comment 2 Nick Sandonato CLA 2010-04-16 10:53:16 EDT 
I believe we should be fixing this because it is an accessibility issue. Bug 185851 put us on the right track towards our editors being more capable in high contrast mode, and the addition of some new style elements in 3.2 were not accounted for in high contrast mode.

The issue at hand is we have new strings that are used as labels for the color definitions used by the theme.
Comment 3 David Williams CLA 2010-04-16 11:11:06 EDT 
I agree. Since accessibility issue.
Comment 4 Nick Sandonato CLA 2010-04-19 13:21:22 EDT 
Fixed.