Bug 305571 - [Forms] Links in forms editors keep getting bolder and bolder
Summary: [Forms] Links in forms editors keep getting bolder and bolder
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: User Assistance (show other bugs)
Version: 3.6   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 3.6 M7   Edit
Assignee: Chris Goldthorpe CLA
QA Contact:
URL:
Whiteboard:
Keywords: polish
Depends on:
Blocks:
 
Reported: 2010-03-11 14:06 EST by Curtis Windatt CLA
Modified: 2010-04-16 16:18 EDT (History)
4 users (show)

See Also:


Attachments
Screenshot depicting the problem in question. (9.17 KB, image/png)
2010-04-15 13:08 EDT, Remy Suen CLA
no flags Details
Screenshot showing problem (70.71 KB, image/png)
2010-04-15 13:10 EDT, Curtis Windatt CLA
no flags Details
Patch (1.31 KB, patch)
2010-04-16 16:17 EDT, Chris Goldthorpe CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Curtis Windatt CLA 2010-03-11 14:06:10 EST
I20100309-0100

I expect that this has already been reported, but I can't find a dupe.  If there isn't a dupe I can provide a screenshot and additional details, but it's easy to reproduce.

Only noticed recently, but in forms editors (manifest editor, dynamic help, etc), links that get bolded/highlighted when hovering over them, remain that way after the hover ends.

By waving the mouse over the links the font gets darker and bolder.
Comment 1 Remy Suen CLA 2010-03-11 14:20:34 EST
This sounds like bug 268402.
Comment 2 Eric Moffatt CLA 2010-04-05 14:53:29 EDT
Remy, just looked at the defect you suggested and there seems to be some confusion as to where it should go (I was at least going to set them both to the same person...), any guesses? BTW, I can't seem to repro on my XP box.
Comment 3 Remy Suen CLA 2010-04-05 15:24:42 EDT
(In reply to comment #2)
> Remy, just looked at the defect you suggested and there seems to be some
> confusion as to where it should go (I was at least going to set them both to
> the same person...), any guesses? BTW, I can't seem to repro on my XP box.

This is (or should be) a problem with UA Forms. I've seen it on XP. It leaves a foul taste in one's mouth.
Comment 4 Chris Goldthorpe CLA 2010-04-07 15:28:19 EDT
Can you list the steps required to reproduce? Also what are the display properties on your XP system, in particular the theme and font size?
Comment 5 Curtis Windatt CLA 2010-04-07 15:43:16 EDT
(In reply to comment #4)
> Can you list the steps required to reproduce? Also what are the display
> properties on your XP system, in particular the theme and font size?

1) Open a workbench
2) Open a forms editor (I used the PDE plug-in and feature editors)
3) Mouseover the links

Happens in my normal workspace and a clean workspace.

This is on Ubuntu 9.10 Karmic using Human-Clearlooks theme.  I'm running at a resolution of 1600 x 1200 and use Gnome 2.28.1.
Comment 6 Remy Suen CLA 2010-04-07 15:54:48 EDT
(In reply to comment #4)
> Can you list the steps required to reproduce? Also what are the display
> properties on your XP system, in particular the theme and font size?

What Curtis said. Hover over them, then back, on and off, and it'll get bolder. I run XP SP3 with the uh...XP blue theme (or whatever the "default" is called, not win2k and not silver theme). Font size I haven't changed at all.
Comment 7 Chris Goldthorpe CLA 2010-04-07 16:08:05 EDT
I'll take a look at this for 3.6. Hopefully my taste buds will survive the experience.
Comment 8 Remy Suen CLA 2010-04-07 16:09:47 EDT
(In reply to comment #7)
> I'll take a look at this for 3.6. Hopefully my taste buds will survive the
> experience.

Bug 268402 comment 4 offers some insight to the problem that may be helpful.
Comment 9 Chris Goldthorpe CLA 2010-04-15 12:59:17 EDT
I'm not seeing this (using N20100411-2000), can you attach a screenshot so I can be sure to hover over the same field where you were seeing the problem. I'm using XP SP3 with the blue theme.
Comment 10 Remy Suen CLA 2010-04-15 13:08:25 EDT
Created attachment 164994 [details]
Screenshot depicting the problem in question.

'Overview' tab of a PDE editor on a MANIFEST.MF file.
Comment 11 Curtis Windatt CLA 2010-04-15 13:10:03 EDT
Created attachment 164995 [details]
Screenshot showing problem

On the extensions tab of the PDE editor for org.eclipse.pde.core (though it happens with all the PDE forms editors).  I don't see the problem with the Mylyn task editor.

In the screenshot one link hasn't been moused over, one link has been moused over once, the last link has been moused over lots of times.

Switching editors clears the bolding.
Comment 12 Chris Goldthorpe CLA 2010-04-15 13:49:28 EDT
OK I can see it now, I'll investigate.
Comment 13 Chris Goldthorpe CLA 2010-04-16 16:17:39 EDT
Created attachment 165143 [details]
Patch

That was hard to track down, it was a regression caused by the fix to Bug 290450. I had renamed a protected method which was overridden in a subclass. Note that the link is the same color as it was before the hover, it was just in a heavier version of the font.
Comment 14 Chris Goldthorpe CLA 2010-04-16 16:18:53 EDT
Patch committed to HEAD.